linux-kernel - Re: [next] mm/shmem.c:3993:5: error: conflicting types for 'shmem_unuse'; have 'int(unsigned int, long unsigned int *)'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b423739-abe6-7e48-1a20-149ae56df108@infradead.org>
Date:   Wed, 5 Jan 2022 18:38:42 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Matthew Wilcox <willy@...radead.org>,
        Naresh Kamboju <naresh.kamboju@...aro.org>
Cc:     linux-mm <linux-mm@...ck.org>,
        open list <linux-kernel@...r.kernel.org>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Hugh Dickins <hughd@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Christoph Hellwig <hch@....de>,
        Juergen Gross <jgross@...e.com>,
        Dan Streetman <ddstreet@...e.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        Seth Jennings <sjenning@...hat.com>,
        Vitaly Wool <vitaly.wool@...sulko.com>,
        lkft-triage@...ts.linaro.org
Subject: Re: [next] mm/shmem.c:3993:5: error: conflicting types for
 'shmem_unuse'; have 'int(unsigned int, long unsigned int *)'



On 1/5/22 09:40, Matthew Wilcox wrote:
> On Wed, Jan 05, 2022 at 08:01:19PM +0530, Naresh Kamboju wrote:
>> mm/shmem.c:3993:5: error: conflicting types for 'shmem_unuse'; have
>> 'int(unsigned int,  long unsigned int *)'
>>  3993 | int shmem_unuse(unsigned int type, unsigned long *fs_pages_to_unuse)
>>       |     ^~~~~~~~~~~
>> In file included from include/linux/khugepaged.h:6,
>>                  from mm/shmem.c:37:
>> include/linux/shmem_fs.h:86:5: note: previous declaration of
>> 'shmem_unuse' with type 'int(unsigned int)'
>>    86 | int shmem_unuse(unsigned int type);
>>       |     ^~~~~~~~~~~
> 
> This is "mm: simplify try_to_unuse" in akpm's tree.
> 
> It needs a fix that looks something like this:

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

thanks.

> 
> +++ b/mm/shmem.c
> @@ -3990,7 +3990,7 @@ int __init shmem_init(void)
>         return 0;
>  }
> 
> -int shmem_unuse(unsigned int type, unsigned long *fs_pages_to_unuse)
> +int shmem_unuse(unsigned int type)
>  {
>         return 0;
>  }
> 

-- 
~Randy