linux-kernel - Re: [PATCH] net/mlx5e: Fix missing error code in mlx5e_rx_reporter_err_icosq_cqe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220106035137.wwfpxejblgbpw66w@sx1>
Date:   Wed, 5 Jan 2022 19:51:37 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     saeedm@...dia.com, leon@...nel.org, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] net/mlx5e: Fix missing error code in
 mlx5e_rx_reporter_err_icosq_cqe_recover()

On Wed, Jan 05, 2022 at 11:17:51PM +0800, Jiapeng Chong wrote:
>The error code is missing in this code scenario, add the error code
>'-EINVAL' to the return value 'err'.
>
>Eliminate the follow smatch warning:
>
>drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c:91
>mlx5e_rx_reporter_err_icosq_cqe_recover() warn: missing error code
>'err'.
>

error code is not missing, err is equal to 0 at this point and the 
code aborts with err = 0 as intended. False alarm. nack.