linux-kernel - Re: [PATCH] fs: ext4: remove duplicate includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YdZrXiDFqnISDlJQ@mit.edu>
Date:   Wed, 5 Jan 2022 23:09:02 -0500
From:   "Theodore Ts'o" <tytso@....edu>
To:     Guo Zhengkui <guozhengkui@...o.com>
Cc:     Andreas Dilger <adilger.kernel@...ger.ca>,
        "open list:EXT4 FILE SYSTEM" <linux-ext4@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>, kernel@...o.com
Subject: Re: [PATCH] fs: ext4: remove duplicate includes

On Tue, Dec 07, 2021 at 05:04:30PM +0800, Guo Zhengkui wrote:
> remove a duplicate "#include <linux/dax.h>".
> 
> Signed-off-by: Guo Zhengkui <guozhengkui@...o.com>

I'm confused.  I can't find any kernel version for which this applies.
Both at HEAD, and for all of 5.x, there is only a single #include of
the linux/dax.h header file:

% for i in $(seq 0 15) ; do git show v5.$i:fs/ext4/inode.c | grep linux/dax.h | wc -l ; done

show that for 5.0..5.15, "linux/dax.h" only appears once in
fs/ext4/inode.c.

						- Ted