linux-kernel - Re: [PATCH 00/17] Add export symbol namespace PL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 Jan 2022 20:26:36 -0800
From:   Gwendal Grignou <gwendal@...omium.org>
To:     Dmitry Torokhov <dtor@...omium.org>
Cc:     bleung@...omium.org, groeck@...omium.org, myungjoo.ham@...sung.com,
        cw00.choi@...sung.com, benjamin.tissoires@...hat.com,
        jic23@...nel.org, hverkuil-cisco@...all.nl, mchehab@...nel.org,
        lee.jones@...aro.org, pmalani@...omium.org, sre@...nel.org,
        thierry.reding@...il.com, u.kleine-koenig@...gutronix.de,
        lgirdwood@...il.com, a.zummo@...ertech.it, cychiang@...omium.org,
        perex@...ex.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/17] Add export symbol namespace PL_CHROMEOS

On Wed, Jan 5, 2022 at 2:58 PM Dmitry Torokhov <dtor@...omium.org> wrote:
>
> Hi Gwendal,
>
> On Wed, Jan 5, 2022 at 2:07 PM Gwendal Grignou <gwendal@...omium.org> wrote:
> >
> > Add a symbol namespace for functions exported by the plaform chromeos
> > subsystem.
>
> It would be great to explain why this is needed/desirable. What are
> the benefits of introducing this namespace? What problem are you
> trying to solve?
The issue came when reviewing an iio sensor
(https://www.spinics.net/lists/linux-iio/msg66280.html). I wanted to
be ahead of the curve (for once).

>
> > Add depenencies for all drivers using these function.
> >
> > 'make nsdeps' is used to fix the dependencies.
> >
> > Signed-off-by: Gwendal Grignou <gwendal@...omium.org>
> >
> > Gwendal Grignou (17):
> >   plaform: chrome: Add PL_CHROMEOS export symbol namespace
> >   iio:cros_ec_sensors: Add PL_CHROMEOS dependency
>
> I wonder if ordering patches this way breaks compilation (patches
> should be structured in such a way that one need not apply entire
> series to get to buildable kernel). Isn't putting symbols into new
> namespace makes them unavailable to modules unless they explicitly
> import it?
>From https://www.kernel.org/doc/html/latest/core-api/symbol-namespaces.html#loading-modules-that-use-namespaced-symbols,
since MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS is set by default, this
is just a warning at load time.

Gwendal.
>
> Thanks.
>
> --
> Dmitry