linux-kernel - Re: [RFC PATCH rdma-next 03/10] RDMA/rxe: Allow registering FLUSH flags for supported device only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33d0f4d4-17e7-8212-c37d-d39454f3f4d3@fujitsu.com>
Date:   Thu, 6 Jan 2022 06:20:57 +0000
From:   "lizhijian@...itsu.com" <lizhijian@...itsu.com>
To:     Jason Gunthorpe <jgg@...pe.ca>,
        "lizhijian@...itsu.com" <lizhijian@...itsu.com>
CC:     "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "zyjzyj2000@...il.com" <zyjzyj2000@...il.com>,
        "aharonl@...dia.com" <aharonl@...dia.com>,
        "leon@...nel.org" <leon@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mbloch@...dia.com" <mbloch@...dia.com>,
        "liangwenpeng@...wei.com" <liangwenpeng@...wei.com>,
        "yangx.jy@...itsu.com" <yangx.jy@...itsu.com>,
        "rpearsonhpe@...il.com" <rpearsonhpe@...il.com>,
        "y-goto@...itsu.com" <y-goto@...itsu.com>
Subject: Re: [RFC PATCH rdma-next 03/10] RDMA/rxe: Allow registering FLUSH
 flags for supported device only



On 06/01/2022 08:22, Jason Gunthorpe wrote:
> On Tue, Dec 28, 2021 at 04:07:10PM +0800, Li Zhijian wrote:
>> Device should enable IB_DEVICE_RDMA_FLUSH capability if it want to
>> support RDMA FLUSH.
>>
>> Signed-off-by: Li Zhijian <lizhijian@...fujitsu.com>
>> ---
>>   include/rdma/ib_verbs.h | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
>> index f04d66539879..51d58b641201 100644
>> --- a/include/rdma/ib_verbs.h
>> +++ b/include/rdma/ib_verbs.h
>> @@ -291,6 +291,7 @@ enum ib_device_cap_flags {
>>   	/* The device supports padding incoming writes to cacheline. */
>>   	IB_DEVICE_PCI_WRITE_END_PADDING		= (1ULL << 36),
>>   	IB_DEVICE_ALLOW_USER_UNREG		= (1ULL << 37),
>> +	IB_DEVICE_RDMA_FLUSH			= (1ULL << 38),
>>   };
>>   
>>   enum ib_atomic_cap {
>> @@ -4319,6 +4320,10 @@ static inline int ib_check_mr_access(struct ib_device *ib_dev,
>>   	if (flags & IB_ACCESS_ON_DEMAND &&
>>   	    !(ib_dev->attrs.device_cap_flags & IB_DEVICE_ON_DEMAND_PAGING))
>>   		return -EINVAL;
>> +
>> +	if (flags & IB_ACCESS_FLUSH &&
>> +	    !(ib_dev->attrs.device_cap_flags & IB_DEVICE_RDMA_FLUSH))
>> +		return -EINVAL;
>>   	return 0;
>>   }
> This needs to be combined with the previous patch
Make sense

Thanks
Zhijian

>
> Jason