linux-kernel - Re: [PATCH linux-next] tools: compiler-gcc.h: Keep compatible with older GCC versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu,  6 Jan 2022 06:25:08 +0000
From:   xu xin <cgel.zte@...il.com>
To:     alexandr.lobakin@...el.com
Cc:     cgel.zte@...il.com, ndesaulniers@...gle.com, keescook@...omium.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        nathan@...nel.org, torvalds@...ux-foundation.org,
        xu.xin16@....com.cn
Subject: Re: [PATCH linux-next] tools: compiler-gcc.h: Keep compatible with older GCC versions

> GNU C    5.1

> This applies to both HOSTCC and CC.

> > Undefined __has_attribute as we built the whole kernel and tools.
> > 
> > To solve this, this patch is given to keep the compatibility with older
> > GCC versions.

Yes, but I think this error is a little unfriendly to users using a 
lower version of host GCC when cross compiling. 

Perhaps "#if gcc_version > = 51000" could be added to avoid the error 
'Undefined __has_attribute' 

or we can add `#error "hostcc don't support _has_attribute` to remind
the user of the cause of the error.

Or just use my previous patch.

I hope we can do something here to promote the situation as Nathan talked
before:

https://lore.kernel.org/all/91B93D4D-BEC8-4ACD-B71F-27C54D8B1B78@kernel.org/