linux-kernel - Re: [PATCH v9 2/4] dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe45a08d6f04f4d6184874782b6c95f6e00f1658.camel@puri.sm>
Date:   Thu, 06 Jan 2022 07:34:57 +0100
From:   Martin Kepplinger <martin.kepplinger@...i.sm>
To:     Rob Herring <robh@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Pavel Machek <pavel@....cz>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@....fi>, devicetree@...r.kernel.org,
        Purism Kernel Team <kernel@...i.sm>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        phone-devel@...r.kernel.org, Shawn Tu <shawnx.tu@...el.com>
Subject: Re: [PATCH v9 2/4] dt-bindings: media: document SK Hynix Hi-846
 MIPI CSI-2 8M pixel sensor

Am Mittwoch, dem 05.01.2022 um 10:23 -0600 schrieb Rob Herring:
> On Fri, Dec 3, 2021 at 10:19 AM Rob Herring <robh@...nel.org> wrote:
> > 
> > On Mon, Sep 6, 2021 at 5:29 AM Martin Kepplinger
> > <martin.kepplinger@...i.sm> wrote:
> > > 
> > > Document the bindings used for the SK Hynix Hi-846 CMOS camera
> > > driver.
> > > 
> > > Signed-off-by: Martin Kepplinger <martin.kepplinger@...i.sm>
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > > Reviewed-by: Rob Herring <robh@...nel.org>
> > > ---
> > >  .../bindings/media/i2c/hynix,hi846.yaml       | 120
> > > ++++++++++++++++++
> > >  1 file changed, 120 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> > > 
> > > diff --git
> > > a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> > > b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> > > new file mode 100644
> > > index 000000000000..85a8877c2f38
> > > --- /dev/null
> > > +++
> > > b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> > > @@ -0,0 +1,120 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/media/i2c/hynix,hi846.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: SK Hynix Hi-846 1/4" 8M Pixel MIPI CSI-2 sensor
> > > +
> > > +maintainers:
> > > +  - Martin Kepplinger <martin.kepplinger@...i.sm>
> > > +
> > > +description: |-
> > > +  The Hi-846 is a raw image sensor with an MIPI CSI-2 image data
> > > +  interface and CCI (I2C compatible) control bus. The output
> > > format
> > > +  is raw Bayer.
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: hynix,hi846
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +  clocks:
> > > +    items:
> > > +      - description: Reference to the mclk clock.
> > > +
> > > +  assigned-clocks:
> > > +    maxItems: 1
> > > +
> > > +  assigned-clock-rates:
> > > +    maxItems: 1
> > > +
> > > +  reset-gpios:
> > > +    description: Reference to the GPIO connected to the RESETB
> > > pin. Active low.
> > > +    maxItems: 1
> > > +
> > > +  shutdown-gpios:
> > > +    description: Reference to the GPIO connected to the
> > > XSHUTDOWN pin. Active low.
> > > +    maxItems: 1
> > > +
> > > +  vddio-supply:
> > > +    description: Definition of the regulator used for the VDDIO
> > > power supply.
> > > +
> > > +  vdda-supply:
> > > +    description: Definition of the regulator used for the VDDA
> > > power supply.
> > > +
> > > +  vddd-supply:
> > > +    description: Definition of the regulator used for the VDDD
> > > power supply.
> > > +
> > > +  port:
> > > +    $ref: /schemas/graph.yaml#/properties/port
> > 
> > This needs to be:
> > 
> > $ref: /schemas/graph.yaml#/$defs/port-base
> > 
> > to fix the warning reported. You have to use the 'main' branch of
> > dtschema which has unevaluatedProperties support. I'll be making a
> > release soonish.
> 
> This is still failing, can you please fix it.
> 
> Rob

Yes I'll send a patch next week. thanks for the reminder,

                           martin