linux-kernel - [narmstrong-oxnas:oxnas/v5.10/sata 5/6] drivers/ata/sata_ox810se.c:667:9: warning: ISO C90 forbids mixed declarations and code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 6 Jan 2022 14:57:37 +0800
From:   kernel test robot <lkp@...el.com>
To:     Neil Armstrong <narmstrong@...libre.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [narmstrong-oxnas:oxnas/v5.10/sata 5/6]
 drivers/ata/sata_ox810se.c:667:9: warning: ISO C90 forbids mixed
 declarations and code

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/narmstrong/linux-oxnas.git oxnas/v5.10/sata
head:   d695ac5686438a814b4bb4231a62f5d5155a1ee1
commit: ebe3f0291c0a549cde22525457385054b77afc91 [5/6] fixup! ata: Add Oxford Semiconductor OX810SE SATA Controller Support
config: xtensa-allyesconfig (https://download.01.org/0day-ci/archive/20220106/202201061417.nHB4vUHX-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/narmstrong/linux-oxnas.git/commit/?id=ebe3f0291c0a549cde22525457385054b77afc91
        git remote add narmstrong-oxnas https://git.kernel.org/pub/scm/linux/kernel/git/narmstrong/linux-oxnas.git
        git fetch --no-tags narmstrong-oxnas oxnas/v5.10/sata
        git checkout ebe3f0291c0a549cde22525457385054b77afc91
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/ata/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/ata/sata_ox810se.c: In function 'ox810sata_check_status':
>> drivers/ata/sata_ox810se.c:667:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     667 |         u32 reg = ox810sata_check_link(priv, ap);
         |         ^~~
   drivers/ata/sata_ox810se.c: At top level:
   drivers/ata/sata_ox810se.c:1599:22: warning: initialized field overwritten [-Woverride-init]
    1599 |         .can_queue = SATA_OXNAS_QUEUE_DEPTH,
         |                      ^~~~~~~~~~~~~~~~~~~~~~
   drivers/ata/sata_ox810se.c:1599:22: note: (near initialization for 'ox810sata_sht.can_queue')


vim +667 drivers/ata/sata_ox810se.c

   651	
   652	/*
   653	 * Reads the Status ATA shadow register from hardware. Due to a fault with PIO
   654	 * transfers, it sometimes necessary to mask out the DRQ bit
   655	 * @param ap hardware with the registers in
   656	 * @return The status register
   657	 */
   658	static u8 ox810sata_check_status(struct ata_port *ap)
   659	{
   660		struct ox810sata_port_priv *pd = (struct ox810sata_port_priv *)ap->private_data;
   661		struct ox810sata_host_priv *priv = pd->priv;
   662		u8 status;
   663	
   664		status = ox810sata_ioportraid_read(priv, ap, ORB2) >> 24;
   665	
   666		// check for the drive going missing indicated by SCR status bits 0-3 = 0
 > 667		u32 reg = ox810sata_check_link(priv, ap);
   668	
   669		if (priv->hw_raid_active)
   670			reg |= ox810sata_check_link(priv, ox810sata_other_ap(priv, ap));
   671	
   672		if (!reg)
   673			status |= ATA_DF | ATA_ERR;
   674	
   675		return status;
   676	}
   677	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org