[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <96521e26-7d51-7451-3cf4-cca37da9dc24@linux.ibm.com>
Date: Thu, 6 Jan 2022 11:00:12 +0100
From: Karsten Graul <kgraul@...ux.ibm.com>
To: Wen Gu <guwen@...ux.alibaba.com>, davem@...emloft.net,
kuba@...nel.org
Cc: linux-s390@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v4] net/smc: Reset conn->lgr when link group
registration fails
On 06/01/2022 07:44, Wen Gu wrote:
> @@ -630,10 +630,11 @@ static int smc_connect_decline_fallback(struct smc_sock *smc, int reason_code,
>
> static void smc_conn_abort(struct smc_sock *smc, int local_first)
> {
> + struct smc_connection *conn = &smc->conn;
> +
> + smc_conn_free(conn);
> if (local_first)
> - smc_lgr_cleanup_early(&smc->conn);
> - else
> - smc_conn_free(&smc->conn);
> + smc_lgr_cleanup_early(conn->lgr);
> }
Looks like I missed a prereq patch here, but wo'nt conn->lgr be set to NULL
after smc_conn_free() called smc_lgr_unregister_conn()?
Powered by blists - more mailing lists