linux-kernel - Re: [PATCH] x86/CPU/AMD: use default_groups in kobj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Jan 2022 11:25:48 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, linux-edac@...r.kernel.org
Subject: Re: [PATCH] x86/CPU/AMD: use default_groups in kobj_type

On Thu, Jan 06, 2022 at 11:15:16AM +0100, Greg Kroah-Hartman wrote:
> There are currently 2 ways to create a set of sysfs files for a
> kobj_type, through the default_attrs field, and the default_groups
> field.  Move the AMD mce sysfs code to use default_groups field which
> has been the preferred way since aa30f47cf666 ("kobject: Add support for
> default attribute groups to kobj_type") so that we can soon get rid of
> the obsolete default_attrs field.
> 
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: x86@...nel.org
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: linux-edac@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  arch/x86/kernel/cpu/mce/amd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c
> index fc85eb17cb6d..08c64884b0a5 100644
> --- a/arch/x86/kernel/cpu/mce/amd.c
> +++ b/arch/x86/kernel/cpu/mce/amd.c
> @@ -1171,6 +1171,7 @@ static struct attribute *default_attrs[] = {
>  	NULL,	/* possibly interrupt_enable if supported, see below */
>  	NULL,
>  };
> +ATTRIBUTE_GROUPS(default);
>  
>  #define to_block(k)	container_of(k, struct threshold_block, kobj)
>  #define to_attr(a)	container_of(a, struct threshold_attr, attr)
> @@ -1207,7 +1208,7 @@ static void threshold_block_release(struct kobject *kobj);
>  
>  static struct kobj_type threshold_ktype = {
>  	.sysfs_ops		= &threshold_ops,
> -	.default_attrs		= default_attrs,
> +	.default_groups		= default_groups,
>  	.release		= threshold_block_release,
>  };
>  
> -- 
> 2.34.1
> 

Oops, nope, more work needs to happen on this change, sorry.  I'll send
out a v2 soon...

thanks,

greg k-h