linux-kernel - Re: [PATCH] nfs: local_lock: handle async processing of F_SETLK with FL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Jan 2022 13:29:57 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     kbuild@...ts.01.org, Vasily Averin <vvs@...tuozzo.com>,
        Trond Myklebust <trond.myklebust@...merspace.com>,
        Anna Schumaker <anna.schumaker@...app.com>
Cc:     lkp@...el.com, kbuild-all@...ts.01.org, kernel@...nvz.org,
        linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfs: local_lock: handle async processing of F_SETLK with
 FL_SLEEP

Hi Vasily,

url:    https://github.com/0day-ci/linux/commits/Vasily-Averin/nfs-local_lock-handle-async-processing-of-F_SETLK-with-FL_SLEEP/20211227-184705
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: i386-randconfig-m021-20211227 (https://download.01.org/0day-ci/archive/20211228/202112281211.SsWl4cfI-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
Reported-by: Dan Carpenter <dan.carpenter@...cle.com>

smatch warnings:
fs/nfs/file.c:772 do_setlk() warn: should this be a bitwise op?

vim +772 fs/nfs/file.c

5eebde23223aeb Suresh Jayaraman 2010-09-23  752  static int
5eebde23223aeb Suresh Jayaraman 2010-09-23  753  do_setlk(struct file *filp, int cmd, struct file_lock *fl, int is_local)
^1da177e4c3f41 Linus Torvalds   2005-04-16  754  {
^1da177e4c3f41 Linus Torvalds   2005-04-16  755  	struct inode *inode = filp->f_mapping->host;
^1da177e4c3f41 Linus Torvalds   2005-04-16  756  	int status;
^1da177e4c3f41 Linus Torvalds   2005-04-16  757  
^1da177e4c3f41 Linus Torvalds   2005-04-16  758  	/*
^1da177e4c3f41 Linus Torvalds   2005-04-16  759  	 * Flush all pending writes before doing anything
^1da177e4c3f41 Linus Torvalds   2005-04-16  760  	 * with locks..
^1da177e4c3f41 Linus Torvalds   2005-04-16  761  	 */
29884df0d89c1d Trond Myklebust  2005-12-13  762  	status = nfs_sync_mapping(filp->f_mapping);
29884df0d89c1d Trond Myklebust  2005-12-13  763  	if (status != 0)
^1da177e4c3f41 Linus Torvalds   2005-04-16  764  		goto out;
^1da177e4c3f41 Linus Torvalds   2005-04-16  765  
5eebde23223aeb Suresh Jayaraman 2010-09-23  766  	/*
5eebde23223aeb Suresh Jayaraman 2010-09-23  767  	 * Use local locking if mounted with "-onolock" or with appropriate
5eebde23223aeb Suresh Jayaraman 2010-09-23  768  	 * "-olocal_lock="
5eebde23223aeb Suresh Jayaraman 2010-09-23  769  	 */
5eebde23223aeb Suresh Jayaraman 2010-09-23  770  	if (!is_local)
^1da177e4c3f41 Linus Torvalds   2005-04-16  771  		status = NFS_PROTO(inode)->lock(filp, cmd, fl);
00e7edbaaa914f Vasily Averin    2021-12-27 @772  	else if ((fl->fl_flags && FL_SLEEP) && IS_SETLK(cmd))
                                                                               ^
&& vs &

00e7edbaaa914f Vasily Averin    2021-12-27  773  		status = posix_lock_file(filp, fl, NULL);
c4d7c402b788b7 Trond Myklebust  2008-04-01  774  	else
75575ddf29cbbf Jeff Layton      2016-09-17  775  		status = locks_lock_file_wait(filp, fl);
00e7edbaaa914f Vasily Averin    2021-12-27  776  	if (status)
^1da177e4c3f41 Linus Torvalds   2005-04-16  777  		goto out;
6b96724e507fec Ricardo Labiaga  2010-10-12  778  
^1da177e4c3f41 Linus Torvalds   2005-04-16  779  	/*
779eafab06036f NeilBrown        2017-08-18  780  	 * Invalidate cache to prevent missing any changes.  If
779eafab06036f NeilBrown        2017-08-18  781  	 * the file is mapped, clear the page cache as well so
779eafab06036f NeilBrown        2017-08-18  782  	 * those mappings will be loaded.
6b96724e507fec Ricardo Labiaga  2010-10-12  783  	 *
^1da177e4c3f41 Linus Torvalds   2005-04-16  784  	 * This makes locking act as a cache coherency point.
^1da177e4c3f41 Linus Torvalds   2005-04-16  785  	 */
29884df0d89c1d Trond Myklebust  2005-12-13  786  	nfs_sync_mapping(filp->f_mapping);
779eafab06036f NeilBrown        2017-08-18  787  	if (!NFS_PROTO(inode)->have_delegation(inode, FMODE_READ)) {
442ce0499c0535 NeilBrown        2017-07-24  788  		nfs_zap_caches(inode);
779eafab06036f NeilBrown        2017-08-18  789  		if (mapping_mapped(filp->f_mapping))
779eafab06036f NeilBrown        2017-08-18  790  			nfs_revalidate_mapping(inode, filp->f_mapping);
779eafab06036f NeilBrown        2017-08-18  791  	}
^1da177e4c3f41 Linus Torvalds   2005-04-16  792  out:
^1da177e4c3f41 Linus Torvalds   2005-04-16  793  	return status;
^1da177e4c3f41 Linus Torvalds   2005-04-16  794  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org