linux-kernel - Re: [PATCH v2 5/5] clk: qcom: lpass: Add support for LPASS clock controller for SC7280

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220106000335.D8364C36AEB@smtp.kernel.org>
Date:   Wed, 05 Jan 2022 16:03:34 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Michael Turquette   <mturquette@...libre.com>,
        Taniya Das <tdas@...eaurora.org>,
        kernel test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, Rajendra Nayak <rnayak@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, robh@...nel.org, robh+dt@...nel.org
Subject: Re: [PATCH v2 5/5] clk: qcom: lpass: Add support for LPASS clock controller for SC7280

Quoting kernel test robot (2021-12-20 17:02:06)
> Hi Taniya,
> 
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on clk/clk-next]
> [also build test WARNING on robh/for-next linus/master v5.16-rc6 next-20211220]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Taniya-Das/Add-support-for-LPASS-Core-and-Audio-Clock-for-SC7280/20211221-004818
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
> config: parisc-allyesconfig (https://download.01.org/0day-ci/archive/20211221/202112210805.wI87zJw0-lkp@intel.com/config)
> compiler: hppa-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/0day-ci/linux/commit/fec640fab5ec498e79475ecd4b15bc95035a76b1
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Taniya-Das/Add-support-for-LPASS-Core-and-Audio-Clock-for-SC7280/20211221-004818
>         git checkout fec640fab5ec498e79475ecd4b15bc95035a76b1
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=parisc SHELL=/bin/bash drivers/clk/qcom/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/clk/qcom/lpassaudiocc-sc7280.c:39:9: warning: this decimal constant is unsigned only in ISO C90
>       39 |         { 595200000, 3600000000, 0 },

This should be easy to fix.

>          |         ^
>    In file included from include/uapi/linux/posix_types.h:5,
>                     from include/uapi/linux/types.h:14,
>                     from include/linux/types.h:6,
>                     from include/linux/of.h:14,
>                     from include/linux/clk-provider.h:9,
>                     from drivers/clk/qcom/lpassaudiocc-sc7280.c:6:
>    drivers/clk/qcom/lpassaudiocc-sc7280.c: In function 'lpass_audio_cc_sc7280_probe':
>    include/linux/stddef.h:8:14: error: called object is not a function or function pointer
>        8 | #define NULL ((void *)0)
>          |              ^
>    include/linux/pm_clock.h:82:25: note: in expansion of macro 'NULL'
>       82 | #define pm_clk_suspend  NULL

This one looks like the driver needs some #ifdef CONFIG_PM somewhere.

>          |                         ^~~~
>    drivers/clk/qcom/lpassaudiocc-sc7280.c:740:9: note: in expansion of macro 'pm_clk_suspend'
>      740 |         pm_clk_suspend(&pdev->dev);
>          |         ^~~~~~~~~~~~~~
>    drivers/clk/qcom/lpassaudiocc-sc7280.c: In function 'lpass_aon_cc_sc7280_probe':
>    include/linux/stddef.h:8:14: error: called object is not a function or function pointer
>        8 | #define NULL ((void *)0)
>          |              ^
>    include/linux/pm_clock.h:82:25: note: in expansion of macro 'NULL'
>       82 | #define pm_clk_suspend  NULL
>          |                         ^~~~
>    drivers/clk/qcom/lpassaudiocc-sc7280.c:798:9: note: in expansion of macro 'pm_clk_suspend'
>      798 |         pm_clk_suspend(&pdev->dev);
>          |         ^~~~~~~~~~~~~~
> 
> 
> vim +39 drivers/clk/qcom/lpassaudiocc-sc7280.c
> 
>     37  
>     38  static const struct pll_vco zonda_vco[] = {
>   > 39          { 595200000, 3600000000, 0 },
>     40  };
>     41  
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org