lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220106125928.bdq76oc22z65zlwk@liuwe-devbox-debian-v2>
Date:   Thu, 6 Jan 2022 12:59:28 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     SeongJae Park <sj@...nel.org>
Cc:     ojeda@...nel.org, alex.gaynor@...il.com, wedsonaf@...gle.com,
        akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        rust-for-linux@...r.kernel.org, Wei Liu <wei.liu@...nel.org>
Subject: Re: [PATCH] init/Kconfig: Specify the interpreter for rust-version.sh

On Thu, Jan 06, 2022 at 12:33:57PM +0000, SeongJae Park wrote:
> Some common tools like 'diff' don't support permissions of the files.
> Due to that, 'rust-version.sh' in some trees including '-mm' result in
> having no execution permission, and therefore build fails like below:
> 
>     $ make O=../linux.out/ olddefconfig
>     make[1]: Entering directory 'linux.out'
>       GEN     Makefile
>     sh: 1: linux/scripts/rust-version.sh: Permission denied
>     init/Kconfig:71: syntax error
>     init/Kconfig:70: invalid statement
>     linux/scripts/kconfig/Makefile:77: recipe for target 'olddefconfig' failed
>     make[2]: *** [olddefconfig] Error 1
>     linux/Makefile:666: recipe for target 'olddefconfig' failed
>     make[1]: *** [olddefconfig] Error 2
>     make[1]: Leaving directory 'linux.out'
>     Makefile:226: recipe for target '__sub-make' failed
>     make: *** [__sub-make] Error 2
> 
> It's not a big deal, but not so fun.  This commit fixes the issue by
> specifying the interpreter for 'rust-version.sh' in the Kconfig file.
> 
> Signed-off-by: SeongJae Park <sj@...nel.org>

Reviewed-by: Wei Liu <wei.liu@...nel.org>

> ---
>  init/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index cd23faa163d1..97ab35692d46 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -67,7 +67,7 @@ config HAS_RUST
>  config RUSTC_VERSION
>  	depends on HAS_RUST
>  	int
> -	default $(shell,$(srctree)/scripts/rust-version.sh $(RUSTC))
> +	default $(shell,/bin/sh $(srctree)/scripts/rust-version.sh $(RUSTC))
>  
>  config CC_CAN_LINK
>  	bool
> -- 
> 2.17.1
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ