linux-kernel - Re: [PATCH 02/56] staging: r8188eu: rename camelcase SetToDs to set_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Jan 2022 15:13:37 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Alberto Merciai <alb3rt0.m3rciai@...il.com>
Cc:     linuxfancy@...glegroups.com,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Michael Straube <straube.linux@...il.com>,
        Martin Kaiser <martin@...ser.cx>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Saurav Girepunje <saurav.girepunje@...il.com>,
        Ivan Safonov <insafonov@...il.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Zameer Manji <zmanji@...il.com>, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/56] staging: r8188eu: rename camelcase SetToDs to
 set_to_ds

On Mon, Jan 03, 2022 at 08:01:37PM +0100, Alberto Merciai wrote:
> Rename camel case macro SetToDs into set_to_ds.
> 
> Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@...il.com>
> ---
>  drivers/staging/r8188eu/core/rtw_mlme_ext.c | 4 ++--
>  drivers/staging/r8188eu/core/rtw_xmit.c     | 2 +-
>  drivers/staging/r8188eu/hal/rtl8188e_cmd.c  | 2 +-
>  drivers/staging/r8188eu/include/wifi.h      | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> index 0aa958f20cd6..6c784134d957 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> @@ -5409,7 +5409,7 @@ static int _issue_nulldata(struct adapter *padapter, unsigned char *da, unsigned
>  	if ((pmlmeinfo->state & 0x03) == WIFI_FW_AP_STATE)
>  		SetFrDs(fctrl);
>  	else if ((pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE)
> -		SetToDs(fctrl);
> +		set_to_ds(fctrl);

This patch will not be needed at all if you take my advice from patch
01.

The goal is to make readable code, not just rename things to pass a perl
script's suggestions :)

thanks,

greg k-h