linux-kernel - Re: [PATCH] parisc: pdc_stable: use default_groups in kobj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f95569dc-1d84-232d-b09f-6d531b1e6261@gmx.de>
Date:   Thu, 6 Jan 2022 15:17:47 +0100
From:   Helge Deller <deller@....de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
        linux-parisc@...r.kernel.org
Subject: Re: [PATCH] parisc: pdc_stable: use default_groups in kobj_type

On 1/6/22 10:51, Greg Kroah-Hartman wrote:
> There are currently 2 ways to create a set of sysfs files for a
> kobj_type, through the default_attrs field, and the default_groups
> field.  Move the parisc pdc_stable sysfs code to use default_groups
> field which has been the preferred way since aa30f47cf666 ("kobject: Add
> support for default attribute groups to kobj_type") so that we can soon
> get rid of the obsolete default_attrs field.
>
> Cc: "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>
> Cc: Helge Deller <deller@....de>
> Cc: linux-parisc@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Applied.

Thanks!
Helge

> ---
>  drivers/parisc/pdc_stable.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/parisc/pdc_stable.c b/drivers/parisc/pdc_stable.c
> index e090978518f1..9513c39719d1 100644
> --- a/drivers/parisc/pdc_stable.c
> +++ b/drivers/parisc/pdc_stable.c
> @@ -482,11 +482,12 @@ static struct attribute *paths_subsys_attrs[] = {
>  	&paths_attr_layer.attr,
>  	NULL,
>  };
> +ATTRIBUTE_GROUPS(paths_subsys);
>
>  /* Specific kobject type for our PDC paths */
>  static struct kobj_type ktype_pdcspath = {
>  	.sysfs_ops = &pdcspath_attr_ops,
> -	.default_attrs = paths_subsys_attrs,
> +	.default_groups = paths_subsys_groups,
>  };
>
>  /* We hard define the 4 types of path we expect to find */
>