linux-kernel - Re: [PATCH v2] iio: humidity: hdc100x: Add ACPI HID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdxV+4_yxJv1H1MZPpu02e2gHUkP55dduUqN7QJ2j6aGg@mail.gmail.com>
Date:   Thu, 6 Jan 2022 16:32:42 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Chris Lesiak <chris.lesiak@...or.com>,
        Matt Ranostay <matt.ranostay@...sulko.com>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] iio: humidity: hdc100x: Add ACPI HID table

On Thu, Jan 6, 2022 at 6:13 AM Kai-Heng Feng
<kai.heng.feng@...onical.com> wrote:
>
> x86 boards may use ACPI HID "TXN1010" to for hdc100x device.

to for --> for the

> So add an ACPI match table for that accordingly.

...

>  - Change the ID to follow ACPI Spec

Is there any evidence Texas Instrument allocated this ID, or you just
created it yourself?
Please, add an excerpt from email from them to confirm this.

...

> +static const struct acpi_device_id __maybe_unused hdc100x_acpi_match[] = {
> +       { "TXN1010" },

> +       { },

No comma is needed.

> +};

> +

No blank line is needed.

> +MODULE_DEVICE_TABLE(acpi, hdc100x_acpi_match);

...

> +               .acpi_match_table = ACPI_PTR(hdc100x_acpi_match),

It's the wrong usage of ACPI_PTR().

>         },

All the comments are applicable to all your patches. Some of them I
already commented on and even kbuild bot has sent you a complaint.

-- 
With Best Regards,
Andy Shevchenko