linux-kernel - Re: [RFC PATCH 1/1] perf arm64: Implement --topdown with metrics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e8c7fb6-97aa-f84e-e594-b6eb2cb674e4@arm.com>
Date:   Thu, 6 Jan 2022 16:33:20 +0000
From:   Andrew Kilroy <andrew.kilroy@....com>
To:     John Garry <john.garry@...wei.com>,
        Ian Rogers <irogers@...gle.com>,
        Andi Kleen <ak@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        acme@...nel.org, Will Deacon <will@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Leo Yan <leo.yan@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [RFC PATCH 1/1] perf arm64: Implement --topdown with metrics



On 15/12/2021 12:53, John Garry wrote:
>>> In addition we could also add a --topdown arg to force using JSON 
>>> metricgroups.
>>>
>>
>> What arg do think would be supplied?
> 
> something like -json or -metricgroup, meaning "Use pmu-events metric 
> events to calculate topdown results rather than kernel CPU PMU events. 
> This is default fallback if the kernel CPU PMU does not support topdown 
> events"
> 

John,

Andi requested that the json metrics be disabled on x86 in

 
https://lore.kernel.org/linux-perf-users/12e0deef-08db-445f-4958-bcd5c3e10367@linux.intel.com/#t

If we do that, do you still think the --topdown=<arg>  modification is 
needed?  I guess it would have to report an error if someone requests 
--topdown=json-metrics on x86.

Thanks,
Andrew