linux-kernel - Re: [PATCH v2 3/3] prlimit: do not grab the tasklist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <699b3962-1b9e-ab76-8dd4-13311fb2c0c9@google.com>
Date:   Thu, 6 Jan 2022 11:43:12 -0500
From:   Barret Rhoden <brho@...gle.com>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     Christian Brauner <christian.brauner@...ntu.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Alexey Gladkov <legion@...nel.org>,
        William Cohen <wcohen@...hat.com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Alexey Dobriyan <adobriyan@...il.com>,
        Chris Hyser <chris.hyser@...cle.com>,
        Peter Collingbourne <pcc@...gle.com>,
        Xiaofeng Cao <caoxiaofeng@...ong.com>,
        David Hildenbrand <david@...hat.com>,
        Cyrill Gorcunov <gorcunov@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] prlimit: do not grab the tasklist_lock

On 1/5/22 17:05, Eric W. Biederman wrote:
> 
> I think the simple solution is just:
> 	update_rlimit_cpu(tsk->group_leader)
> 
> As the group leader is guaranteed to be the last thread of the thread
> group to be processed in release_task, and thus the last thread with a
> sighand.  Nothing needs to be done if it does not have a sighand.

Ah, good to know.  I didn't know the group_leader stuck around as a 
zombie.  That makes life easier.  I'll make the change and repost the 
patches.

Thanks,

Barret