linux-kernel - Re: debugfs: Directory with parent 'regmap' already present!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ydcl4bkdxco1UeuI@sirena.org.uk>
Date:   Thu, 6 Jan 2022 17:24:49 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Fabio Estevam <festevam@...il.com>
Cc:     Matthias Schiffer <matthias.schiffer@...tq-group.com>,
        Lee Jones <lee.jones@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: debugfs: Directory with parent 'regmap' already present!

On Thu, Jan 06, 2022 at 01:57:15PM -0300, Fabio Estevam wrote:
> On Thu, Jan 6, 2022 at 9:07 AM Mark Brown <broonie@...nel.org> wrote:

> The duplicate "dummy-iomuxc-gpr@...0000" comes from the lack of doing
> a kfree(map->debugfs_name);
> 
> Calling 'kfree(map->debugfs_name);' like this:

That doesn't sound like a good idea - if this does anything we must be
looking at the data so only adding frees will only translate using the
wrong data into a dereference of a freed pointer which seems worse.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)