linux-kernel - Re: Re: [PATCH] thunderbolt: Check for null pointer after calling kmemdup in icm_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220106005223.2480738-1-jiasheng@iscas.ac.cn>
Date:   Thu,  6 Jan 2022 08:52:23 +0800
From:   Jiasheng Jiang <jiasheng@...as.ac.cn>
To:     gregkh@...uxfoundation.org
Cc:     mika.westerberg@...ux.intel.com, andreas.noever@...il.com,
        michael.jamet@...el.com, YehezkelShB@...il.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jiasheng Jiang <jiasheng@...as.ac.cn>
Subject: Re: Re: [PATCH] thunderbolt: Check for null pointer after calling kmemdup in icm_handle_event

On Wed, Jan 05, 2022 at 06:21:57PM +0800, Greg KH wrote:
> I can not understand this changelog text at all, sorry.  Please read the
> documentation for how to write a good changelog text.

Thanks, I will correct my changelog from now on.

> And most importantly, how did you test this change?

Actually, all I did is just to read the description of the kmemdup()
and then add the check.
I don't think it is necessary to test, for the patch is just to make
the system more robust, but not to introduce a new function, which is
needed to test to guarantee the normal operation.
Anyway, there is a previous patch that has already fixed the bug.

Sincerely thanks,
Jiang