linux-kernel - Re: [PATCH 07/24] ARM: dts: exynos: override pins by label in Peach Pi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Jan 2022 00:14:42 +0530
From:   Alim Akhtar <alim.akhtar@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     Tomasz Figa <tomasz.figa@...il.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Sylwester Nawrocki <snawrocki@...nel.org>,
        Sam Protsenko <semen.protsenko@...aro.org>,
        Chanho Park <chanho61.park@...sung.com>
Subject: Re: [PATCH 07/24] ARM: dts: exynos: override pins by label in Peach Pi

Hi Krzysztof,

On Sat, Jan 1, 2022 at 1:15 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...onical.com> wrote:
>
> Using node paths to extend or override a device tree node is error
> prone.  If there was a typo error, a new node will be created instead of
> extending the existing node.  This will lead to run-time errors that
> could be hard to detect.
>
> A mistyped label on the other hand, will cause a dtc compile error
> (during build time).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

>  arch/arm/boot/dts/exynos5800-peach-pi.dts | 33 +++++++++++------------
>  1 file changed, 16 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> index 77013ee586f8..6bf3fd37fb2b 100644
> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> @@ -850,27 +850,26 @@ pmic_dvs_1: pmic-dvs-1 {
>         };
>  };
>
> -&pinctrl_1 {
> -       /* Adjust WiFi drive strengths lower for EMI */
> -       sd1_clk: sd1-clk {
> -               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> -       };
> +/* pinctrl_1 */
> +/* Adjust WiFi drive strengths lower for EMI */
> +&sd1_bus1 {
> +       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> +};
>
> -       sd1_cmd: sd1-cmd {
> -               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> -       };
> +&sd1_bus4 {
> +       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> +};
>
> -       sd1_bus1: sd1-bus-width1 {
> -               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> -       };
> +&sd1_bus8 {
> +       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> +};
>
> -       sd1_bus4: sd1-bus-width4 {
> -               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> -       };
> +&sd1_clk {
> +       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> +};
>
> -       sd1_bus8: sd1-bus-width8 {
> -               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> -       };
> +&sd1_cmd {
> +       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
>  };
>
>  &pinctrl_2 {
> --
> 2.32.0
>


-- 
Regards,
Alim