linux-kernel - Re: [PATCH] tcp: tcp_send_challenge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20220106183540.6826f285@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 6 Jan 2022 18:35:49 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     yan2228598786@...il.com
Cc:     edumazet@...gle.com, davem@...emloft.net, yoshfuji@...ux-ipv6.org,
        dsahern@...nel.org, ast@...nel.org, daniel@...earbox.net,
        andrii@...nel.org, kafai@...com, songliubraving@...com, yhs@...com,
        john.fastabend@...il.com, kpsingh@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        bpf@...r.kernel.org, Benjamin <yan2228598786@...il.com>
Subject: Re: [PATCH] tcp: tcp_send_challenge_ack delete useless param `skb`

On Thu,  6 Jan 2022 08:32:45 +0800 Benjamin.Yim yan2228598786@...il.com
wrote:
> From: Benjamin <yan2228598786@...il.com>
> 
> After this parameter is passed in, there is no usage, and deleting it will
>  not bring any impact.
> 
> Signed-off-by: Benjamin <yan2228598786@...il.com>

This one did not make it to patchwork or lore.

Please resend. Perhaps the reason was the odd looking From header:

From: Benjamin.Yim yan2228598786@...il.com

Maybe it should have <> brackets? Please also use your full name for
the patch author and sign-off - should you be "Benjamin Yim"?