lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Jan 2022 14:28:53 +1100 From: Herbert Xu <herbert@...dor.apana.org.au> To: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com> Cc: "David S. Miller" <davem@...emloft.net>, Vitaly Chikunov <vt@...linux.org>, Eric Biggers <ebiggers@...gle.com>, Eric Biggers <ebiggers@...nel.org>, Gilad Ben-Yossef <gilad@...yossef.com>, Ard Biesheuvel <ardb@...nel.org>, Jussi Kivilinna <jussi.kivilinna@....fi>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, "H. Peter Anvin" <hpa@...or.com>, linux-crypto@...r.kernel.org, x86@...nel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 2/6] crypto: arm64/sm3-ce - make dependent on sm3 library On Thu, Dec 23, 2021 at 12:35:43PM +0800, Tianjia Zhang wrote: > SM3 generic library is stand-alone implementation, sm3-ce can depend > on the SM3 library instead of sm3-generic. > > Signed-off-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com> > --- > arch/arm64/crypto/Kconfig | 2 +- > arch/arm64/crypto/sm3-ce-glue.c | 20 ++++++++++++++------ > 2 files changed, 15 insertions(+), 7 deletions(-) This doesn't compile cleanly with C=1 W=1: CC [M] arch/arm64/crypto/sm3-ce-glue.o AS [M] arch/arm64/crypto/sm3-ce-core.o CC [M] arch/arm64/crypto/sm4-ce-glue.o CHECK ../arch/arm64/crypto/sha3-ce-glue.c ../arch/arm64/crypto/sm3-ce-glue.c: In function ‘sm3_ce_update’: ../arch/arm64/crypto/sm3-ce-glue.c:30:10: error: void value not ignored as it ought to be 30 | return sm3_update(shash_desc_ctx(desc), data, len); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../arch/arm64/crypto/sm3-ce-glue.c: In function ‘sm3_ce_final’: ../arch/arm64/crypto/sm3-ce-glue.c:42:10: error: void value not ignored as it ought to be 42 | return sm3_final(shash_desc_ctx(desc), out); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ make[3]: *** [../scripts/Makefile.build:287: arch/arm64/crypto/sm3-ce-glue.o] Error 1 make[3]: *** Waiting for unfinished jobs.... Please make sure everything builds cleanly with C=1 W=1 *before* you submit. Thanks, -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists