linux-kernel - Re: [PATCH v2] crypto: af_alg - check possible NULL pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yde0s8CAr30qrCoj@gondor.apana.org.au>
Date:   Fri, 7 Jan 2022 14:34:11 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     ebiggers@...nel.org, davem@...emloft.net,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] crypto: af_alg - check possible NULL pointer

On Fri, Dec 31, 2021 at 09:40:36AM +0800, Jiasheng Jiang wrote:
> Because of the possible alloc failure of the alloc_page(), it could
> return NULL pointer.
> And there is a check below the sg_assign_page().
> But it will be more logical to move the NULL check before the
> sg_assign_page().
> 
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
> ---
> Changelog:
> 
> v1 -> v2
> 
> * Change 1. Move the previous check in front of sg_assign_page().
> ---
>  crypto/af_alg.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

Patch applied with modified Subject line.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt