linux-kernel - Re: [RFC 00/32] Kconfig: Introduce HAS_IOPORT and LEGACY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64d4b0d66379affd59c5a24ddb71a8f208330362.camel@linux.ibm.com>
Date:   Fri, 07 Jan 2022 08:21:41 +0100
From:   Niklas Schnelle <schnelle@...ux.ibm.com>
To:     John Garry <john.garry@...wei.com>,
        Arnd Bergmann <arnd@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Nick Hu <nickhu@...estech.com>,
        Greentime Hu <green.hu@...il.com>,
        Vincent Chen <deanbo422@...il.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>, Guo Ren <guoren@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linux-csky@...r.kernel.org
Subject: Re: [RFC 00/32] Kconfig: Introduce HAS_IOPORT and LEGACY_PCI options

On Thu, 2022-01-06 at 17:45 +0000, John Garry wrote:
> Hi Niklas,
> 
> On 27/12/2021 16:42, Niklas Schnelle wrote:
> > I performed the following testing:
> > 
> > - On s390 this series on top of v5.16-rc7 builds with allyesconfig i.e. the
> >    HAS_IOPORT=n case.
> 
> Are you sure that allyesconfig gives HAS_IOPORT=n? Indeed I see no 
> mechanism is always disallow HAS_IOPORT for s390 (which I think we would 
> want).
> 
> > It also builds with defconfig and the resulting kernel
> >    appears fully functional including tests with PCI devices.
> 
> Thanks,
> Johnw
> 

I checked again by adding

config HAS_IOPORT
       def_bool n

in arch/s390/Kconfig and that doesn't seem to make a difference,
allyesconfig builds all the same. Also checked for CONFIG_HAS_IOPORT in
my .config and that isn't listed with or without the above addition.

I think this is because without a help text there is no "config
question" and thus nothing that allyesconfig would set to yes. I do
agree though that it's better to be explicit and add the above to those
Kconfigs that don't support HAS_IOPORT.
Thanks,
Niklas