linux-kernel - Re: [PATCH 5/6] staging: vc04_services: rename macros BM2835_MMAL_VERSION and BM2835_MMAL_MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 7 Jan 2022 07:36:20 -0300
From:   Gaston Gonzalez <gascoar@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-staging@...ts.linux.dev, nsaenz@...nel.org,
        f.fainelli@...il.com, rjui@...adcom.com, sbranden@...adcom.com,
        juerg.haefliger@...onical.com, rdunlap@...radead.org,
        dave.stevenson@...pberrypi.com, stefan.wahren@...e.com,
        unixbhaskar@...il.com, mitaliborkar810@...il.com,
        phil@...pberrypi.com, len.baker@....com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        bcm-kernel-feedback-list@...adcom.com,
        linux-kernel@...r.kernel.org, gascoar@...il.com
Subject: Re: [PATCH 5/6] staging: vc04_services: rename macros
 BM2835_MMAL_VERSION and BM2835_MMAL_MODULE_NAME

On Thu, Jan 06, 2022 at 02:48:25PM +0100, Greg KH wrote:
> On Wed, Jan 05, 2022 at 05:35:47PM -0300, Gaston Gonzalez wrote:
> > In the kernel, all names related to the chip BCM2835 are always named
> > bcm2835_*. To avoid confusion, and to make things more consistent,
> > rename the macros BM2835_MMAL_VERSION and BM2835_MMAL_MODULE_NAME
> > accordingly.
> > 
> > While at it, some realignments were made to improve readability.
> > 
> > Suggested-by: Stefan Wahren <stefan.wahren@...e.com>
> > Signed-off-by: Gaston Gonzalez <gascoar@...il.com>
> > ---
> >  .../vc04_services/bcm2835-camera/bcm2835-camera.c  | 14 ++++++--------
> >  1 file changed, 6 insertions(+), 8 deletions(-)
> > 
> > diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
> > index aaf529f2186c..c729b1b7de71 100644
> > --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
> > +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
> > @@ -33,8 +33,8 @@
> >  #include "mmal-parameters.h"
> >  #include "bcm2835-camera.h"
> >  
> > -#define BM2835_MMAL_VERSION "0.0.2"
> > -#define BM2835_MMAL_MODULE_NAME "bcm2835-v4l2"
> > +#define BCM2835_MMAL_VERSION "0.0.2"
> 
> MODULE_VERSION means nothing when the code is in the kernel tree, this
> shold just be removed entirely.
> 
> > +#define BCM2835_MMAL_MODULE_NAME "bcm2835-v4l2"
> 
> KBUILD_MODULE_NAME provides this, please delete this and just use that
> instead.
> 
> This can be 2 different commits because of this.
> 
> thanks,
> 
> greg k-h
> 

Hi Greg,

Thanks for reviewing.

Ok, will do.

Gaston