linux-kernel - Re: [PATCH] fs/pipe: local vars has to match types of proper pipe_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 7 Jan 2022 13:06:19 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Andrei Vagin <avagin@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org,
        Dmitry Safonov <0x7f454c46@...il.com>
Subject: Re: [PATCH] fs/pipe: local vars has to match types of proper
 pipe_inode_info fields

On Thu, Jan 06, 2022 at 09:19:46AM -0800, Andrei Vagin wrote:
> head, tail, ring_size are declared as unsigned int, so all local
> variables that operate with these fields have to be unsigned to avoid
> signed integer overflow.
> 
> Right now, it isn't an issue because the maximum pipe size is limited by
> 1U<<31.
> 
> Cc: Dmitry Safonov <0x7f454c46@...il.com>
> Suggested-by: Dmitry Safonov <0x7f454c46@...il.com>
> Signed-off-by: Andrei Vagin <avagin@...il.com>
> ---

Looks good,
Acked-by: Christian Brauner <christian.brauner@...ntu.com>