linux-kernel - Re: [PATCH v6 3/3] mmc: Add driver for LiteX's LiteSDCard interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ydgy0mCMJFkZqWAb@antec>
Date:   Fri, 7 Jan 2022 21:32:18 +0900
From:   Stafford Horne <shorne@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        "Gabriel L. Somlo" <gsomlo@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        Karol Gugala <kgugala@...micro.com>,
        Mateusz Holenko <mholenko@...micro.com>,
        Kamil Rakoczy <krakoczy@...micro.com>,
        mdudek@...ernships.antmicro.com,
        Paul Mackerras <paulus@...abs.org>,
        Joel Stanley <joel@....id.au>, david.abdurachmanov@...ive.com,
        Florent Kermarrec <florent@...oy-digital.fr>,
        Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH v6 3/3] mmc: Add driver for LiteX's LiteSDCard interface

On Fri, Jan 07, 2022 at 12:24:23PM +0200, Andy Shevchenko wrote:
> On Fri, Jan 7, 2022 at 12:12 PM Stafford Horne <shorne@...il.com> wrote:
> > On Fri, Jan 07, 2022 at 10:36:12AM +0100, Geert Uytterhoeven wrote:
> > > On Thu, Jan 6, 2022 at 11:50 PM Gabriel L. Somlo <gsomlo@...il.com> wrote:
> 
> ...
> 
> > > Many (most?) blurbs do mention the module name.
> >
> > I was doubting this as well, but I searched and its true.  The text 'module will
> > be called' shows up many times, there is also different text.
> >
> >  $ grep -r 'module will be called' drivers/ | wc
> >    1347    9023   9086
> >
> >  $ grep -r 'tristate \"' drivers/ | wc
> >    7169   47486  521795
> 
> Just a side note: `git grep ...` is much faster in the Git trees.

Yes, it is quite a lot faster, I always wondered why one would use it rather
than just grep.  Thanks for the tip.

    < shorne@...ec ~/work/linux > time grep -r 'module will be called' drivers/ >/dev/null

    real    0m0.338s
    user    0m0.220s
    sys     0m0.113s

    < shorne@...ec ~/work/linux > time git grep 'module will be called' -- drivers/ >/dev/null

    real    0m0.153s
    user    0m0.205s
    sys     0m0.659s


> And for this particular case I dare to advertise a script I wrote [1]
> to help with recursive searches.
> 
> [1]: https://github.com/andy-shev/home-bin-tools/blob/master/gl4func.sh

Neat script.

> > So maybe >10% have module name in the blurb.  Example:
> >
> >           To compile this driver as a module, choose M here: the
> >           module will be called tifm_sd.
> 
> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko