linux-kernel - Re: [PATCH] dt-bindings: remoteproc: ti: Fix the number of mailboxes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 7 Jan 2022 11:21:34 -0600
From:   Rob Herring <robh@...nel.org>
To:     Suman Anna <s-anna@...com>
Cc:     Ohad Ben-Cohen <ohad@...ery.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" 
        <linux-remoteproc@...r.kernel.org>, devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Nagalla, Hari" <hnagalla@...com>
Subject: Re: [PATCH] dt-bindings: remoteproc: ti: Fix the number of mailboxes

On Fri, Jan 7, 2022 at 8:17 AM Suman Anna <s-anna@...com> wrote:
>
> On 1/7/22 8:13 AM, Suman Anna wrote:
> > Hi Rob,
> >
> > On 1/6/22 9:04 PM, Rob Herring wrote:
> >> Based on the example, the TI K3 DSP and R5 have 2 mailboxes, but the schema
> >> says 1. Fix the schema.
> >
> > No, 1 is correct. The OMAP Mailbox binding uses #mbox-cells as 1 and not 0, and
> > uses a phandle as the cell-value.

That's unfortunate. Really, ti,mbox-tx/rx should have been the mbox
cells with 2 entries (rx and tx)...

>
> The following is what you get with your current patch,
>
> Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dt.yaml:
> dsp@...0800000: mboxes: [[4294967295, 4294967295]] is too short
> Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dt.yaml:
> dsp@...00000: mboxes: [[4294967295, 4294967295]] is too short

Ugg, yes. What I'm working on is getting validation on dtb files to
work. That means the dts <> are lost and we have to either parse the
properties properly (look up #foo-cells) or use __fixups__ to find
unresolved phandles (the case for most examples). The latter works
most of the time except a few cases like above. So the fix here is to
add a mbox provider node to the example.

Rob