linux-kernel - Re: [PATCH rdma-next v1 1/7] RDMA/mlx5: Merge similar flows of allocating MR from the cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220107200701.GA3107651@nvidia.com>
Date:   Fri, 7 Jan 2022 16:07:01 -0400
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Aharon Landau <aharonl@...dia.com>, linux-kernel@...r.kernel.org,
        linux-rdma@...r.kernel.org
Subject: Re: [PATCH rdma-next v1 1/7] RDMA/mlx5: Merge similar flows of
 allocating MR from the cache

On Thu, Dec 30, 2021 at 01:23:18PM +0200, Leon Romanovsky wrote:

>  	if (list_empty(&ent->head)) {
> +		if (ent->limit) {
> +			queue_adjust_cache_locked(ent);
> +			ent->miss++;
> +		}

I don't this this addition of ent->limit makes any sense.

The only case it triggers is the two ODP callers and they should
definately increment miss.

queue_adjust_cache_locked() is an effective NOP if limit is zero as
available_mrs should be zero too.

Jason