lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Sat, 8 Jan 2022 23:09:26 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [mingo-tip:master 2179/2300]
 drivers/media/v4l2-core/v4l2-jpeg.c:598:1: error: type defaults to 'int' in
 declaration of 'EXPORT_SYMBOL_GPL'

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git master
head:   4e348e961395297bb17f101cc63bc133d8a348e9
commit: a23091e5fc3db81c73c7214417fb662df6b00a74 [2179/2300] headers/deps: modules: Optimize <linux/buildid.h> dependencies, remove <linux/mm_types.h> inclusion
config: sparc64-randconfig-r014-20220108 (https://download.01.org/0day-ci/archive/20220108/202201082354.KA8yfwUC-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git/commit/?id=a23091e5fc3db81c73c7214417fb662df6b00a74
        git remote add mingo-tip git://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git
        git fetch --no-tags mingo-tip master
        git checkout a23091e5fc3db81c73c7214417fb662df6b00a74
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc64 SHELL=/bin/bash drivers/media/v4l2-core/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

>> drivers/media/v4l2-core/v4l2-jpeg.c:598:1: warning: data definition has no type or storage class
     598 | EXPORT_SYMBOL_GPL(v4l2_jpeg_parse_header);
         | ^~~~~~~~~~~~~~~~~
>> drivers/media/v4l2-core/v4l2-jpeg.c:598:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Werror=implicit-int]
>> drivers/media/v4l2-core/v4l2-jpeg.c:598:1: warning: parameter names (without types) in function declaration
   drivers/media/v4l2-core/v4l2-jpeg.c:617:1: warning: data definition has no type or storage class
     617 | EXPORT_SYMBOL_GPL(v4l2_jpeg_parse_frame_header);
         | ^~~~~~~~~~~~~~~~~
   drivers/media/v4l2-core/v4l2-jpeg.c:617:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Werror=implicit-int]
   drivers/media/v4l2-core/v4l2-jpeg.c:617:1: warning: parameter names (without types) in function declaration
   drivers/media/v4l2-core/v4l2-jpeg.c:636:1: warning: data definition has no type or storage class
     636 | EXPORT_SYMBOL_GPL(v4l2_jpeg_parse_scan_header);
         | ^~~~~~~~~~~~~~~~~
   drivers/media/v4l2-core/v4l2-jpeg.c:636:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Werror=implicit-int]
   drivers/media/v4l2-core/v4l2-jpeg.c:636:1: warning: parameter names (without types) in function declaration
   drivers/media/v4l2-core/v4l2-jpeg.c:657:1: warning: data definition has no type or storage class
     657 | EXPORT_SYMBOL_GPL(v4l2_jpeg_parse_quantization_tables);
         | ^~~~~~~~~~~~~~~~~
   drivers/media/v4l2-core/v4l2-jpeg.c:657:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Werror=implicit-int]
   drivers/media/v4l2-core/v4l2-jpeg.c:657:1: warning: parameter names (without types) in function declaration
   drivers/media/v4l2-core/v4l2-jpeg.c:678:1: warning: data definition has no type or storage class
     678 | EXPORT_SYMBOL_GPL(v4l2_jpeg_parse_huffman_tables);
         | ^~~~~~~~~~~~~~~~~
   drivers/media/v4l2-core/v4l2-jpeg.c:678:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Werror=implicit-int]
   drivers/media/v4l2-core/v4l2-jpeg.c:678:1: warning: parameter names (without types) in function declaration
   cc1: some warnings being treated as errors


vim +598 drivers/media/v4l2-core/v4l2-jpeg.c

b8035f7988a82c Mirela Rabulea 2021-03-11  481  
50733b5b9102da Philipp Zabel  2020-03-18  482  /**
a4184b4f99019f Hans Verkuil   2021-03-03  483   * v4l2_jpeg_parse_header - locate marker segments and optionally parse headers
50733b5b9102da Philipp Zabel  2020-03-18  484   * @buf: address of the JPEG buffer, should start with a SOI marker
50733b5b9102da Philipp Zabel  2020-03-18  485   * @len: length of the JPEG buffer
50733b5b9102da Philipp Zabel  2020-03-18  486   * @out: returns marker segment positions and optionally parsed headers
50733b5b9102da Philipp Zabel  2020-03-18  487   *
50733b5b9102da Philipp Zabel  2020-03-18  488   * The out->scan_header pointer must be initialized to NULL or point to a valid
50733b5b9102da Philipp Zabel  2020-03-18  489   * v4l2_jpeg_scan_header structure. The out->huffman_tables and
50733b5b9102da Philipp Zabel  2020-03-18  490   * out->quantization_tables pointers must be initialized to NULL or point to a
50733b5b9102da Philipp Zabel  2020-03-18  491   * valid array of 4 v4l2_jpeg_reference structures each.
50733b5b9102da Philipp Zabel  2020-03-18  492   *
50733b5b9102da Philipp Zabel  2020-03-18  493   * Returns 0 or negative error if parsing failed.
50733b5b9102da Philipp Zabel  2020-03-18  494   */
50733b5b9102da Philipp Zabel  2020-03-18  495  int v4l2_jpeg_parse_header(void *buf, size_t len, struct v4l2_jpeg_header *out)
50733b5b9102da Philipp Zabel  2020-03-18  496  {
50733b5b9102da Philipp Zabel  2020-03-18  497  	struct jpeg_stream stream;
50733b5b9102da Philipp Zabel  2020-03-18  498  	int marker;
50733b5b9102da Philipp Zabel  2020-03-18  499  	int ret = 0;
50733b5b9102da Philipp Zabel  2020-03-18  500  
50733b5b9102da Philipp Zabel  2020-03-18  501  	stream.curr = buf;
50733b5b9102da Philipp Zabel  2020-03-18  502  	stream.end = stream.curr + len;
50733b5b9102da Philipp Zabel  2020-03-18  503  
50733b5b9102da Philipp Zabel  2020-03-18  504  	out->num_dht = 0;
50733b5b9102da Philipp Zabel  2020-03-18  505  	out->num_dqt = 0;
50733b5b9102da Philipp Zabel  2020-03-18  506  
ccbea178db47bf Mirela Rabulea 2021-03-11  507  	/* the first bytes must be SOI, B.2.1 High-level syntax */
ccbea178db47bf Mirela Rabulea 2021-03-11  508  	if (jpeg_get_word_be(&stream) != SOI)
50733b5b9102da Philipp Zabel  2020-03-18  509  		return -EINVAL;
50733b5b9102da Philipp Zabel  2020-03-18  510  
b8035f7988a82c Mirela Rabulea 2021-03-11  511  	/* init value to signal if this marker is not present */
b8035f7988a82c Mirela Rabulea 2021-03-11  512  	out->app14_tf = V4L2_JPEG_APP14_TF_UNKNOWN;
b8035f7988a82c Mirela Rabulea 2021-03-11  513  
50733b5b9102da Philipp Zabel  2020-03-18  514  	/* loop through marker segments */
50733b5b9102da Philipp Zabel  2020-03-18  515  	while ((marker = jpeg_next_marker(&stream)) >= 0) {
50733b5b9102da Philipp Zabel  2020-03-18  516  		switch (marker) {
50733b5b9102da Philipp Zabel  2020-03-18  517  		/* baseline DCT, extended sequential DCT */
50733b5b9102da Philipp Zabel  2020-03-18  518  		case SOF0 ... SOF1:
50733b5b9102da Philipp Zabel  2020-03-18  519  			ret = jpeg_reference_segment(&stream, &out->sof);
50733b5b9102da Philipp Zabel  2020-03-18  520  			if (ret < 0)
50733b5b9102da Philipp Zabel  2020-03-18  521  				return ret;
50733b5b9102da Philipp Zabel  2020-03-18  522  			ret = jpeg_parse_frame_header(&stream, marker,
50733b5b9102da Philipp Zabel  2020-03-18  523  						      &out->frame);
50733b5b9102da Philipp Zabel  2020-03-18  524  			break;
50733b5b9102da Philipp Zabel  2020-03-18  525  		/* progressive, lossless */
50733b5b9102da Philipp Zabel  2020-03-18  526  		case SOF2 ... SOF3:
50733b5b9102da Philipp Zabel  2020-03-18  527  		/* differential coding */
50733b5b9102da Philipp Zabel  2020-03-18  528  		case SOF5 ... SOF7:
50733b5b9102da Philipp Zabel  2020-03-18  529  		/* arithmetic coding */
50733b5b9102da Philipp Zabel  2020-03-18  530  		case SOF9 ... SOF11:
50733b5b9102da Philipp Zabel  2020-03-18  531  		case SOF13 ... SOF15:
50733b5b9102da Philipp Zabel  2020-03-18  532  		case DAC:
50733b5b9102da Philipp Zabel  2020-03-18  533  		case TEM:
50733b5b9102da Philipp Zabel  2020-03-18  534  			return -EINVAL;
50733b5b9102da Philipp Zabel  2020-03-18  535  
50733b5b9102da Philipp Zabel  2020-03-18  536  		case DHT:
50733b5b9102da Philipp Zabel  2020-03-18  537  			ret = jpeg_reference_segment(&stream,
50733b5b9102da Philipp Zabel  2020-03-18  538  					&out->dht[out->num_dht++ % 4]);
50733b5b9102da Philipp Zabel  2020-03-18  539  			if (ret < 0)
50733b5b9102da Philipp Zabel  2020-03-18  540  				return ret;
819f3ea51d476d Mirela Rabulea 2021-03-11  541  			if (!out->huffman_tables) {
819f3ea51d476d Mirela Rabulea 2021-03-11  542  				ret = jpeg_skip_segment(&stream);
819f3ea51d476d Mirela Rabulea 2021-03-11  543  				break;
819f3ea51d476d Mirela Rabulea 2021-03-11  544  			}
50733b5b9102da Philipp Zabel  2020-03-18  545  			ret = jpeg_parse_huffman_tables(&stream,
50733b5b9102da Philipp Zabel  2020-03-18  546  							out->huffman_tables);
50733b5b9102da Philipp Zabel  2020-03-18  547  			break;
50733b5b9102da Philipp Zabel  2020-03-18  548  		case DQT:
50733b5b9102da Philipp Zabel  2020-03-18  549  			ret = jpeg_reference_segment(&stream,
50733b5b9102da Philipp Zabel  2020-03-18  550  					&out->dqt[out->num_dqt++ % 4]);
50733b5b9102da Philipp Zabel  2020-03-18  551  			if (ret < 0)
50733b5b9102da Philipp Zabel  2020-03-18  552  				return ret;
819f3ea51d476d Mirela Rabulea 2021-03-11  553  			if (!out->quantization_tables) {
819f3ea51d476d Mirela Rabulea 2021-03-11  554  				ret = jpeg_skip_segment(&stream);
819f3ea51d476d Mirela Rabulea 2021-03-11  555  				break;
819f3ea51d476d Mirela Rabulea 2021-03-11  556  			}
50733b5b9102da Philipp Zabel  2020-03-18  557  			ret = jpeg_parse_quantization_tables(&stream,
50733b5b9102da Philipp Zabel  2020-03-18  558  					out->frame.precision,
50733b5b9102da Philipp Zabel  2020-03-18  559  					out->quantization_tables);
50733b5b9102da Philipp Zabel  2020-03-18  560  			break;
50733b5b9102da Philipp Zabel  2020-03-18  561  		case DRI:
50733b5b9102da Philipp Zabel  2020-03-18  562  			ret = jpeg_parse_restart_interval(&stream,
50733b5b9102da Philipp Zabel  2020-03-18  563  							&out->restart_interval);
50733b5b9102da Philipp Zabel  2020-03-18  564  			break;
b8035f7988a82c Mirela Rabulea 2021-03-11  565  		case APP14:
b8035f7988a82c Mirela Rabulea 2021-03-11  566  			ret = jpeg_parse_app14_data(&stream,
b8035f7988a82c Mirela Rabulea 2021-03-11  567  						    &out->app14_tf);
b8035f7988a82c Mirela Rabulea 2021-03-11  568  			break;
50733b5b9102da Philipp Zabel  2020-03-18  569  		case SOS:
50733b5b9102da Philipp Zabel  2020-03-18  570  			ret = jpeg_reference_segment(&stream, &out->sos);
50733b5b9102da Philipp Zabel  2020-03-18  571  			if (ret < 0)
50733b5b9102da Philipp Zabel  2020-03-18  572  				return ret;
50733b5b9102da Philipp Zabel  2020-03-18  573  			ret = jpeg_parse_scan_header(&stream, out->scan);
50733b5b9102da Philipp Zabel  2020-03-18  574  			/*
50733b5b9102da Philipp Zabel  2020-03-18  575  			 * stop parsing, the scan header marks the beginning of
50733b5b9102da Philipp Zabel  2020-03-18  576  			 * the entropy coded segment
50733b5b9102da Philipp Zabel  2020-03-18  577  			 */
50733b5b9102da Philipp Zabel  2020-03-18  578  			out->ecs_offset = stream.curr - (u8 *)buf;
50733b5b9102da Philipp Zabel  2020-03-18  579  			return ret;
50733b5b9102da Philipp Zabel  2020-03-18  580  
50733b5b9102da Philipp Zabel  2020-03-18  581  		/* markers without parameters */
50733b5b9102da Philipp Zabel  2020-03-18  582  		case RST0 ... RST7: /* restart */
50733b5b9102da Philipp Zabel  2020-03-18  583  		case SOI: /* start of image */
50733b5b9102da Philipp Zabel  2020-03-18  584  		case EOI: /* end of image */
50733b5b9102da Philipp Zabel  2020-03-18  585  			break;
50733b5b9102da Philipp Zabel  2020-03-18  586  
50733b5b9102da Philipp Zabel  2020-03-18  587  		/* skip unknown or unsupported marker segments */
50733b5b9102da Philipp Zabel  2020-03-18  588  		default:
50733b5b9102da Philipp Zabel  2020-03-18  589  			ret = jpeg_skip_segment(&stream);
50733b5b9102da Philipp Zabel  2020-03-18  590  			break;
50733b5b9102da Philipp Zabel  2020-03-18  591  		}
50733b5b9102da Philipp Zabel  2020-03-18  592  		if (ret < 0)
50733b5b9102da Philipp Zabel  2020-03-18  593  			return ret;
50733b5b9102da Philipp Zabel  2020-03-18  594  	}
50733b5b9102da Philipp Zabel  2020-03-18  595  
50733b5b9102da Philipp Zabel  2020-03-18  596  	return marker;
50733b5b9102da Philipp Zabel  2020-03-18  597  }
50733b5b9102da Philipp Zabel  2020-03-18 @598  EXPORT_SYMBOL_GPL(v4l2_jpeg_parse_header);
50733b5b9102da Philipp Zabel  2020-03-18  599  

:::::: The code at line 598 was first introduced by commit
:::::: 50733b5b9102da5b2415e3497aa89588396e4f20 media: add v4l2 JPEG helpers

:::::: TO: Philipp Zabel <p.zabel@...gutronix.de>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ