linux-kernel - arch/nds32/kernel/ftrace.c:24:35: warning: comparison of distinct pointer types lacks a cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 8 Jan 2022 23:19:45 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Steven Rostedt (VMware)" <rostedt@...dmis.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Masami Hiramatsu <mhiramat@...nel.org>
Subject: arch/nds32/kernel/ftrace.c:24:35: warning: comparison of distinct
 pointer types lacks a cast

Hi Steven,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   d1587f7bfe9a0f97a75d42ac1489aeda551106bc
commit: d19ad0775dcd64b49eecf4fa79c17959ebfbd26b ftrace: Have the callbacks receive a struct ftrace_regs instead of pt_regs
date:   1 year, 2 months ago
config: nds32-randconfig-r031-20220108 (https://download.01.org/0day-ci/archive/20220108/202201082355.mNQ1jHlv-lkp@intel.com/config)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d19ad0775dcd64b49eecf4fa79c17959ebfbd26b
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout d19ad0775dcd64b49eecf4fa79c17959ebfbd26b
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   arch/nds32/kernel/ftrace.c: In function '_mcount':
>> arch/nds32/kernel/ftrace.c:24:35: warning: comparison of distinct pointer types lacks a cast
      24 |         if (ftrace_trace_function != ftrace_stub)
         |                                   ^~
>> arch/nds32/kernel/ftrace.c:29:36: warning: cast between incompatible function types from 'void (*)(long unsigned int,  long unsigned int,  struct ftrace_ops *, struct ftrace_regs *)' to 'void (*)(struct ftrace_graph_ret *)' [-Wcast-function-type]
      29 |         if (ftrace_graph_return != (trace_func_graph_ret_t)ftrace_stub
         |                                    ^
   arch/nds32/kernel/ftrace.c: At top level:
   arch/nds32/kernel/ftrace.c:198:6: warning: no previous prototype for 'prepare_ftrace_return' [-Wmissing-prototypes]
     198 | void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr,
         |      ^~~~~~~~~~~~~~~~~~~~~


vim +24 arch/nds32/kernel/ftrace.c

a18082575c6648 Zong Li 2018-08-15  17  
a18082575c6648 Zong Li 2018-08-15  18  noinline void _mcount(unsigned long parent_ip)
a18082575c6648 Zong Li 2018-08-15  19  {
a18082575c6648 Zong Li 2018-08-15  20  	/* save all state by the compiler prologue */
a18082575c6648 Zong Li 2018-08-15  21  
a18082575c6648 Zong Li 2018-08-15  22  	unsigned long ip = (unsigned long)__builtin_return_address(0);
a18082575c6648 Zong Li 2018-08-15  23  
a18082575c6648 Zong Li 2018-08-15 @24  	if (ftrace_trace_function != ftrace_stub)
a18082575c6648 Zong Li 2018-08-15  25  		ftrace_trace_function(ip - MCOUNT_INSN_SIZE, parent_ip,
a18082575c6648 Zong Li 2018-08-15  26  				      NULL, NULL);
a18082575c6648 Zong Li 2018-08-15  27  
1e9b14c0d92b61 Zong Li 2018-08-15  28  #ifdef CONFIG_FUNCTION_GRAPH_TRACER
1e9b14c0d92b61 Zong Li 2018-08-15 @29  	if (ftrace_graph_return != (trace_func_graph_ret_t)ftrace_stub
1e9b14c0d92b61 Zong Li 2018-08-15  30  	    || ftrace_graph_entry != ftrace_graph_entry_stub)
1e9b14c0d92b61 Zong Li 2018-08-15  31  		ftrace_graph_caller();
1e9b14c0d92b61 Zong Li 2018-08-15  32  #endif
1e9b14c0d92b61 Zong Li 2018-08-15  33  
a18082575c6648 Zong Li 2018-08-15  34  	/* restore all state by the compiler epilogue */
a18082575c6648 Zong Li 2018-08-15  35  }
a18082575c6648 Zong Li 2018-08-15  36  EXPORT_SYMBOL(_mcount);
1e9b14c0d92b61 Zong Li 2018-08-15  37  

:::::: The code at line 24 was first introduced by commit
:::::: a18082575c664847d36c6ca030b09ce8d93aec2f nds32/ftrace: Support static function tracer

:::::: TO: Zong Li <zong@...estech.com>
:::::: CC: Greentime Hu <greentime@...estech.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org