linux-kernel - Re: [PATCH] notifier/panic: Introduce panic_notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c2923957-9719-ef23-802a-24765ead7630@igalia.com>
Date:   Sat, 8 Jan 2022 12:36:32 -0300
From:   "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     "kexec@...ts.infradead.org" <kexec@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dyoung@...hat.com" <dyoung@...hat.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "bhe@...hat.com" <bhe@...hat.com>,
        "vgoyal@...hat.com" <vgoyal@...hat.com>,
        "stern@...land.harvard.edu" <stern@...land.harvard.edu>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "corbet@....net" <corbet@....net>,
        "halves@...onical.com" <halves@...onical.com>,
        "kernel@...ccoli.net" <kernel@...ccoli.net>
Subject: Re: [PATCH] notifier/panic: Introduce panic_notifier_filter

On 07/01/2022 20:07, Andy Shevchenko wrote:
> [...] 
>     +       if (!buf)
>     +               return -EINVAL;
> 
> 
> I also implied that you don’t need this condition.
> 
>     +       while ((func = strsep(&buf, ","))) {
>     +               addr = kallsyms_lookup_name(func);
> 
>  
> 
>     +
> 
> 
> Btw, this is redundant blank line.
>  
> 
>     +               if (!addr) {

Thanks Andy, just submitted a V4 that incorporates your suggestions.
Cheers,


Guilherme