linux-kernel - Re: Re: [PATCH v3] ide: Check for null pointer after calling devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat,  8 Jan 2022 11:55:52 +0800
From:   Jiasheng Jiang <jiasheng@...as.ac.cn>
To:     damien.lemoal@...nsource.wdc.com, David.Laight@...LAB.COM,
        davem@...emloft.net, gregkh@...uxfoundation.org,
        stable@...r.kernel.org
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jiasheng Jiang <jiasheng@...as.ac.cn>
Subject: Re: Re: [PATCH v3] ide: Check for null pointer after calling devm_ioremap

On Sat, Jan 08, 2022 at 10:53:42PM +0800, Damien Le Moal wrote:
>> Cc: stable@...r.kernel.org#5.10
>
> Please keep the space before the #
>
> Cc: stable@...r.kernel.org #5.10

Actually, I added the space before, but the when I use the tool
'scripts/checkpatch.pl' to check my format, it told me a warning
that it should not have space.

The warning is as follow:
WARNING: email address 'stable@...r.kernel.org #5.10' might be
better as 'stable@...r.kernel.org#5.10'

So I have no idea what is correct.
Is the tool outdated?
If so, I will correct my cc and please update the tool.

> As commented before, what exactly was corrected ? That is what needs to be
> mentioned here. In any case, I fail to see what code change you added between v2
> and v3. The code changes are identical in the 2 versions.

Thanks, I will make the changelog more clear.
In fact, in the v2 I was careless to write '!!alt_base'.
So I removed the redundant '!' in v3.

Please tell me the right cc format, and then I will submit a new v3,
without the problems above.

Sincerely thanks,
Jiang