linux-kernel - Re: [PATCH] tracing: Remove duplicate warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220109101611.73da76d9@rorschach.local.home>
Date:   Sun, 9 Jan 2022 10:16:11 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Yuntao Wang <ytcoode@...il.com>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: Remove duplicate warnings

On Sun,  9 Jan 2022 21:48:58 +0800
Yuntao Wang <ytcoode@...il.com> wrote:

> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index 92be9cb1d7d4..d7da46df16c5 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -3462,7 +3462,6 @@ create_event_toplevel_files(struct dentry *parent, struct trace_array *tr)
>  	entry = trace_create_file("enable", TRACE_MODE_WRITE, d_events,
>  				  tr, &ftrace_tr_enable_fops);
>  	if (!entry) {
> -		pr_warn("Could not create tracefs 'enable' entry\n");
>  		return -ENOMEM;
>  	}

If it is becoming a simple condition then you don't need the braces.

	if (!entry)
		return -ENOMEM;

-- Steve