lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 9 Jan 2022 18:30:55 +0100 From: Christophe JAILLET <christophe.jaillet@...adoo.fr> To: Jesse Brandeburg <jesse.brandeburg@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org> Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, Christoph Hellwig <hch@....de>, Alexander Lobakin <alexandr.lobakin@...el.com>, intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org Subject: Re: [PATCH] i40e: Remove useless DMA-32 fallback configuration Le 09/01/2022 à 18:14, Christophe JAILLET a écrit : > As stated in [1], dma_set_mask() with a 64-bit mask never fails if > dev->dma_mask is non-NULL. > So, if it fails, the 32 bits case will also fail for the same reason. > > So, if dma_set_mask_and_coherent() succeeds, 'pci_using_dac' is known to be > 1. > > Simplify code and remove some dead code accordingly. > > [1]: https://lkml.org/lkml/2021/6/7/398 > > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> > Reviewed-by: Christoph Hellwig <hch@....de> > Reviewed-by: Alexander Lobakin <alexandr.lobakin@...el.com> > --- > drivers/net/ethernet/intel/e1000e/netdev.c | 22 +++++++--------------- > 1 file changed, 7 insertions(+), 15 deletions(-) NAK, wrong subject CJ
Powered by blists - more mailing lists