linux-kernel - Re: [PATCH v9 3/3] mmc: Add driver for LiteX's LiteSDCard interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YdpiOaJLJN7lOadu@glsvmlin.ini.cmu.edu>
Date:   Sat, 8 Jan 2022 23:19:05 -0500
From:   "Gabriel L. Somlo" <gsomlo@...il.com>
To:     Hillf Danton <hdanton@...a.com>
Cc:     linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
        Kamil Rakoczy <krakoczy@...micro.com>,
        Maciej Dudek <mdudek@...ernships.antmicro.com>,
        Paul Mackerras <paulus@...abs.org>, rdunlap@...radead.org,
        andy.shevchenko@...il.com
Subject: Re: [PATCH v9 3/3] mmc: Add driver for LiteX's LiteSDCard interface

On Sun, Jan 09, 2022 at 10:50:42AM +0800, Hillf Danton wrote:
> On Sat,  8 Jan 2022 11:11:34 -0500 Gabriel Somlo wrote:
> > +
> > +	/* LiteSDCard can support 64-bit DMA addressing */
> > +	ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
> > +	if (ret)
> > +		return ret;
> > +
> > +	host->buf_size = mmc->max_req_size * 2;
> > +	host->buffer = dmam_alloc_coherent(dev, host->buf_size,
> > +					   &host->dma, GFP_DMA);
> 
> GFP_DMA can not make much sence given the above comment.

I'll change it to GFP_KERNEL in v10. Thanks for catching that,
--Gabriel