linux-kernel - Re: [PATCH] pcmcia: fix setting of kthread task states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YdtEENWI7IF2Tpc0@casper.infradead.org>
Date:   Sun, 9 Jan 2022 20:22:40 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Dominik Brodowski <linux@...inikbrodowski.net>
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] pcmcia: fix setting of kthread task states

On Sun, Jan 09, 2022 at 09:14:15PM +0100, Dominik Brodowski wrote:
> We need to set TASK_INTERRUPTIBLE before calling kthread_should_stop().
> Otherwise, kthread_stop() might see that the pccardd thread is still
> in TASK_RUNNING state and fail to wake it up.
> 
> Additonally, we only need to set the state back to TASK_RUNNING if
> kthread_should_stop() breaks the loop.
> 
> Cc: Matthew Wilcox <willy@...radead.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Reported-by: Al Viro <viro@...IV.linux.org.uk>
> Fixes: d3046ba809ce ("pcmcia: fix a boot time warning in pcmcia cs code")
> Signed-off-by: Dominik Brodowski <linux@...inikbrodowski.net>

Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>