linux-kernel - Re: [PATCH] counter: 104-quad-8: Add COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220109212251.xzwilquctuij5lev@pengutronix.de>
Date:   Sun, 9 Jan 2022 22:22:51 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     William Breathitt Gray <vilhelm.gray@...il.com>
Cc:     Jonathan.Cameron@...wei.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Syed Nayyar Waris <syednwaris@...il.com>
Subject: Re: [PATCH] counter: 104-quad-8: Add COMPILE_TEST depends

On Wed, Jan 05, 2022 at 06:41:37PM +0900, William Breathitt Gray wrote:
> 104_QUAD_8 depends on X86, but compiles fine on ARCH=arm. This patch
> adds support for COMPILE_TEST which is useful for compile testing code
> changes to the driver and Counter subsystem.
> 
> Suggested-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Cc: Syed Nayyar Waris <syednwaris@...il.com>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>
> ---
>  drivers/counter/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> index 3dcdb681c4e4..5edd155f1911 100644
> --- a/drivers/counter/Kconfig
> +++ b/drivers/counter/Kconfig
> @@ -14,7 +14,7 @@ if COUNTER
>  
>  config 104_QUAD_8
>  	tristate "ACCES 104-QUAD-8 driver"
> -	depends on PC104 && X86
> +	depends on (PC104 && X86) || COMPILE_TEST

The driver uses inb and friends. Without looking I wonder if there is
something like HAVE_IO or similar this needs to depend on for that?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)