linux-kernel - Re: [PATCH 1/4] drivers/net/virtio_net: Fixed padded vheader to use v1 with hash.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220109142145.54447b38@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Sun, 9 Jan 2022 14:21:45 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrew Melnychenko <andrew@...nix.com>
Cc:     netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, davem@...emloft.net,
        jasowang@...hat.com, mst@...hat.com, yan@...nix.com,
        yuri.benditovich@...nix.com
Subject: Re: [PATCH 1/4] drivers/net/virtio_net: Fixed padded vheader to use
 v1 with hash.

On Sun,  9 Jan 2022 23:06:56 +0200 Andrew Melnychenko wrote:
> The header v1 provides additional info about RSS.
> Added changes to computing proper header length.
> In the next patches, the header may contain RSS hash info
> for the hash population.
> 
> Signed-off-by: Andrew Melnychenko <andrew@...nix.com>

You can't break build in between patches:

drivers/net/virtio_net.c: In function ‘page_to_skb’:
drivers/net/virtio_net.c:398:15: error: ‘struct virtnet_info’ has no member named ‘has_rss_hash_report’
  398 |         if (vi->has_rss_hash_report)
      |               ^~