linux-kernel - Re: [PATCH] bcache: use default_groups in kobj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Jan 2022 23:53:10 +0800
From:   Coly Li <colyli@...e.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Kent Overstreet <kent.overstreet@...il.com>,
        linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcache: use default_groups in kobj_type

On 1/8/22 4:31 PM, Greg Kroah-Hartman wrote:
> On Sat, Jan 08, 2022 at 02:16:28PM +0800, Coly Li wrote:
>> On 1/6/22 6:00 PM, Greg Kroah-Hartman wrote:
>>> There are currently 2 ways to create a set of sysfs files for a
>>> kobj_type, through the default_attrs field, and the default_groups
>>> field.  Move the bcache sysfs code to use default_groups field which has
>>> been the preferred way since aa30f47cf666 ("kobject: Add support for
>>> default attribute groups to kobj_type") so that we can soon get rid of
>>> the obsolete default_attrs field.
>>>
>>> Cc: Coly Li <colyli@...e.de>
>>> Cc: Kent Overstreet <kent.overstreet@...il.com>
>>> Cc: linux-bcache@...r.kernel.org
>>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> It looks good to me.
>>
>> Acked-by: Coly Li <colyli@...e.de>
>>
>> I assume you may take this patch directly in your maintenance path, but if
>> you want me to take this, just let me know. Thanks.
> I can take it myself, or you can, which ever is easiest for you, just
> let me know which you prefer.  Thanks for the review!

It will be faster for this patch goes into mainline in your path, I am 
on vacation now and will have a latency...

Thank you.

Coly Li