linux-kernel - Re: [PATCH 1/3] staging: most: dim2: update renesas compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Jan 2022 16:58:23 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Nikita Yushchenko <nikita.yoush@...entembedded.com>
Cc:     Magnus Damm <magnus.damm@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Christian Gromm <christian.gromm@...rochip.com>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, linux-staging@...ts.linux.dev,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] staging: most: dim2: update renesas compatible string

Hi Nikita,

On Sun, Dec 26, 2021 at 9:25 AM Nikita Yushchenko
<nikita.yoush@...entembedded.com> wrote:
> Use "renesas,rcar-gen3-mlp" instead of "rcar,medialb-dim2"
> - the documented vendor prefix for Renesas is "renesas,"
> - existing r-car devices use "rcar-genN-XXX" pattern.
>
> There are currently no in-tree users to update.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@...entembedded.com>

Thanks for your patch!

> --- a/drivers/staging/most/dim2/dim2.c
> +++ b/drivers/staging/most/dim2/dim2.c
> @@ -1086,7 +1086,7 @@ static const struct of_device_id dim2_of_match[] = {
>                 .data = plat_data + RCAR_H2
>         },
>         {
> -               .compatible = "rcar,medialb-dim2",
> +               .compatible = "renesas,rcar-gen3-mlp",
>                 .data = plat_data + RCAR_M3
>         },

Looks sane, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

But there is no DT binding documentation covering this block :-(

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds