linux-kernel - Re: [PATCH] drivers/soundwire: remove redundant val variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <25f49c99-3feb-dfdc-1077-2f3552ce2ef1@intel.com>
Date:   Mon, 10 Jan 2022 17:31:37 +0100
From:   Cezary Rojewski <cezary.rojewski@...el.com>
To:     <cgel.zte@...il.com>, <agross@...nel.org>
CC:     <bjorn.andersson@...aro.org>, <vkoul@...nel.org>,
        <yung-chuan.liao@...ux.intel.com>,
        <pierre-louis.bossart@...ux.intel.com>, <sanyog.r.kale@...el.com>,
        <linux-arm-msm@...r.kernel.org>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>,
        Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] drivers/soundwire: remove redundant val variable

On 2022-01-10 11:47 AM, cgel.zte@...il.com wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Return value from SWRM_REG_VAL_PACK() directly instead
> of taking this in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@...il.com>
> ---
>   drivers/soundwire/qcom.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
> index 54813417ef8e..77f9c90370be 100644
> --- a/drivers/soundwire/qcom.c
> +++ b/drivers/soundwire/qcom.c
> @@ -235,7 +235,6 @@ static int qcom_swrm_cpu_reg_write(struct qcom_swrm_ctrl *ctrl, int reg,
>   static u32 swrm_get_packed_reg_val(u8 *cmd_id, u8 cmd_data,
>   				   u8 dev_addr, u16 reg_addr)
>   {
> -	u32 val;
>   	u8 id = *cmd_id;
>   
>   	if (id != SWR_BROADCAST_CMD_ID) {
> @@ -245,9 +244,8 @@ static u32 swrm_get_packed_reg_val(u8 *cmd_id, u8 cmd_data,
>   			id = 0;
>   		*cmd_id = id;
>   	}
> -	val = SWRM_REG_VAL_PACK(cmd_data, dev_addr, id, reg_addr);
>   
> -	return val;
> +	return SWRM_REG_VAL_PACK(cmd_data, dev_addr, id, reg_addr);
>   }
>   
>   static int swrm_wait_for_rd_fifo_avail(struct qcom_swrm_ctrl *swrm)
> 

Hello,

While the change looks good, the subject (commit title) seems off. 
Please take a look at commit titles found in drivers/soundwire, you'll 
find several good candidates there.


Regards,
Czarek