linux-kernel - Re: [PATCH v3] iio: st_sensors: don't always auto-enable I2C and SPI interface drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ydx/Qam3mCl416JP@smile.fi.intel.com>
Date:   Mon, 10 Jan 2022 20:47:29 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Nikita Yushchenko <nikita.yoush@...entembedded.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Alexandru Ardelean <aardelean@...iqon.com>,
        Cai Huoqing <caihuoqing@...du.com>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] iio: st_sensors: don't always auto-enable I2C and SPI
 interface drivers

On Mon, Jan 10, 2022 at 08:04:35PM +0300, Nikita Yushchenko wrote:
> 10.01.2022 18:53, Andy Shevchenko wrote:
> > On Mon, Jan 10, 2022 at 06:24:32PM +0300, Nikita Yushchenko wrote:

...

> > The same question as per v2.
> > 
> > > +	default I2C && IIO_ST_ACCEL_3AXIS
> > 
> > What will be the results when I2C=y and the second ones =m?
> 
> $ grep CONFIG_I2C= .config
> CONFIG_I2C=y
> $ grep IIO_ST_ACCEL .config
> CONFIG_IIO_ST_ACCEL_3AXIS=m
> CONFIG_IIO_ST_ACCEL_I2C_3AXIS=m
> # CONFIG_IIO_ST_ACCEL_SPI_3AXIS is not set
> 
> $ vim .config
> <remove CONFIG_IIO_ST_ACCEL_I2C_3AXIS line>
> $ grep IIO_ST_ACCEL .config
> CONFIG_IIO_ST_ACCEL_3AXIS=m
> # CONFIG_IIO_ST_ACCEL_SPI_3AXIS is not set
> 
> $ make menuconfig
> <immediately exit>
> 
> $ grep IIO_ST_ACCEL .config
> CONFIG_IIO_ST_ACCEL_3AXIS=m
> CONFIG_IIO_ST_ACCEL_I2C_3AXIS=m
> # CONFIG_IIO_ST_ACCEL_SPI_3AXIS is not set
> 
> CONFIG_IIO_ST_ACCEL_I2C_3AXIS was set to =m by default. I believe this is correct behavior.

Yes, thanks for confirming.

-- 
With Best Regards,
Andy Shevchenko