linux-kernel - RE: [PATCH v6 07/21] x86/fpu: Provide fpu_enable_guest_xfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB527688C6B00A14C61B97ABE08C509@BN9PR11MB5276.namprd11.prod.outlook.com>
Date:   Mon, 10 Jan 2022 05:25:14 +0000
From:   "Tian, Kevin" <kevin.tian@...el.com>
To:     Paolo Bonzini <pbonzini@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>
CC:     "Zeng, Guang" <guang.zeng@...el.com>,
        "Liu, Jing2" <jing2.liu@...el.com>,
        "Christopherson,, Sean" <seanjc@...gle.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "Wang, Wei W" <wei.w.wang@...el.com>,
        "Zhong, Yang" <yang.zhong@...el.com>
Subject: RE: [PATCH v6 07/21] x86/fpu: Provide fpu_enable_guest_xfd_features()
 for KVM

Hi, Paolo,

> From: Paolo Bonzini <pbonzini@...hat.com>
> Sent: Saturday, January 8, 2022 2:55 AM
> 
> +/*
> +  * fpu_enable_guest_xfd_features - Check xfeatures against guest perm
> and enable
> +  * @guest_fpu:         Pointer to the guest FPU container
> +  * @xfeatures:         Features requested by guest CPUID
> +  *
> +  * Enable all dynamic xfeatures according to guest perm and requested
> CPUID.
> +  *
> +  * Return: 0 on success, error code otherwise
> +  */

Just a NIT. This function itself has nothing to do with guest CPUID
which is a caller-side policy. It simply enable xfeatures per request.

Thanks
Kevin