linux-kernel - Re: [PATCH] drm/amdkfd: Check for null pointer after calling kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0c34571c-6330-9258-a6cb-6886b170e8cb@amd.com>
Date:   Mon, 10 Jan 2022 16:23:30 -0500
From:   Felix Kuehling <felix.kuehling@....com>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>, alexander.deucher@....com,
        christian.koenig@....com, airlied@...ux.ie, daniel@...ll.ch
Cc:     dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdkfd: Check for null pointer after calling kmemdup

On 2022-01-05 10:56 a.m., Felix Kuehling wrote:
> Am 2022-01-05 um 4:09 a.m. schrieb Jiasheng Jiang:
>> As the possible failure of the allocation, kmemdup() may return NULL
>> pointer.
>> Therefore, it should be better to check the 'props2' in order to prevent
>> the dereference of NULL pointer.
>>
>> Fixes: 3a87177eb141 ("drm/amdkfd: Add topology support for dGPUs")
>> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@....com>
I applied the patch to amd-staging-drm-next.

Regards,
   Felix


>
>> ---
>>   drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
>> index c60e82697385..d15380c65c6d 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
>> @@ -410,6 +410,9 @@ static int kfd_parse_subtype_iolink(struct crat_subtype_iolink *iolink,
>>   			return -ENODEV;
>>   		/* same everything but the other direction */
>>   		props2 = kmemdup(props, sizeof(*props2), GFP_KERNEL);
>> +		if (!props2)
>> +			return -ENOMEM;
>> +
>>   		props2->node_from = id_to;
>>   		props2->node_to = id_from;
>>   		props2->kobj = NULL;