linux-kernel - Re: [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0b84be2-55b5-64e7-d39a-c3cd3f46d443@samsung.com>
Date:   Mon, 10 Jan 2022 23:20:49 +0100
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Jaehoon Chung <jh80.chung@...sung.com>,
        Chanho Park <chanho61.park@...sung.com>,
        Sam Protsenko <semen.protsenko@...aro.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Sylwester Nawrocki <snawrocki@...nel.org>, stable@...r.kernel.org
Subject: Re: [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration
 in Exynos5250

On 30.12.2021 20:53, Krzysztof Kozlowski wrote:
> The gpa1-4 pin was put twice in UART3 pin configuration of Exynos5250,
> instead of proper pin gpa1-5.
>
> Fixes: f8bfe2b050f3 ("ARM: dts: add pin state information in client nodes for Exynos5 platforms")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>

Well, the uart3_data node is not referenced anywhere, so this change is 
not really relevant to any board, but for the completeness, feel free to 
add:

Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>


> ---
>   arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> index d31a68672bfa..d7d756614edd 100644
> --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> @@ -260,7 +260,7 @@ i2c3_hs_bus: i2c3-hs-bus {
>   	};
>   
>   	uart3_data: uart3-data {
> -		samsung,pins = "gpa1-4", "gpa1-4";
> +		samsung,pins = "gpa1-4", "gpa1-5";
>   		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
>   		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
>   		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland