[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAP-5=fWU+JBpqpE0ujGfs5TmnY9mv5CWNdMc=X_zKe79GTvPfw@mail.gmail.com>
Date: Mon, 10 Jan 2022 14:22:34 -0800
From: Ian Rogers <irogers@...gle.com>
To: John Garry <john.garry@...wei.com>
Cc: Andi Kleen <ak@...ux.intel.com>, Jiri Olsa <jolsa@...hat.com>,
Namhyung Kim <namhyung@...nel.org>,
Kajol Jain <kjain@...ux.ibm.com>,
"Paul A . Clarke" <pc@...ibm.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Riccardo Mancini <rickyman7@...il.com>,
Kan Liang <kan.liang@...ux.intel.com>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
Vineet Singh <vineet.singh@...el.com>,
James Clark <james.clark@....com>,
Mathieu Poirier <mathieu.poirier@...aro.org>,
Suzuki K Poulose <suzuki.poulose@....com>,
Mike Leach <mike.leach@...aro.org>,
Leo Yan <leo.yan@...aro.org>, coresight@...ts.linaro.org,
linux-arm-kernel@...ts.infradead.org, zhengjun.xing@...el.com,
eranian@...gle.com
Subject: Re: [PATCH v4 04/48] perf stat: Switch aggregation to use for_each loop
On Mon, Jan 10, 2022 at 10:51 AM John Garry <john.garry@...wei.com> wrote:
>
> On 05/01/2022 06:13, Ian Rogers wrote:
> > + cpus = evsel__cpus(evsel);
> > + perf_cpu_map__for_each_cpu(cpu, idx, cpus) {
>
> It seems a common pattern to evaluate cpus and use in
> perf_cpu_map__for_each_cpu() - is it possible to make a macro to accept
> evsel and create cpus, like perf_evsel__for_each_cpu()?
It's possible, I'm not sure it is saving much and it is common to also
want to iterate the cpumap of the evlist.
Thanks,
Ian
> > + if (cpu_map__compare_aggr_cpu_id(config->aggr_get_id(config, cpus, idx),
> > + id))
> > + return cpu;
> > }
> > return 0;
>
Powered by blists - more mailing lists