linux-kernel - Re: [PATCH v3] ata: libata-scsi: simplify __ata_scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5b404e0e-837f-4e97-857f-542bd0b1e48e@opensource.wdc.com>
Date:   Tue, 11 Jan 2022 08:59:17 +0900
From:   Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To:     Wenchao Hao <haowenchao@...wei.com>, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Zhiqiang Liu <liuzhiqiang26@...wei.com>
Subject: Re: [PATCH v3] ata: libata-scsi: simplify __ata_scsi_queuecmd()

On 1/6/22 09:13, Wenchao Hao wrote:
> This is just a clean code. Since each branch of "if" state would check
> scmd->cmd_len, so move the check of scmd->cmd_len out of "if" state to
> simplify parameters check.
> 
> After the check of scmd->cmd_len is out of "if" state, we can remove
> one redundant "if" state.
> 
> Remove a redundant variable "rc" by hand.
> 
> This patch do not change origin function logic.
> 
> Signed-off-by: Wenchao Hao <haowenchao@...wei.com>

Applied to for-5.17 with some changes to the commit message to clarify
the changes.
Thanks.

-- 
Damien Le Moal
Western Digital Research