linux-kernel - Re: [PATCH] RDMA/hns: Fix missing put_device call in hns_roce_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YdvjzJuSHTQfSONA@unreal>
Date:   Mon, 10 Jan 2022 09:44:12 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Wenpeng Liang <liangwenpeng@...wei.com>,
        Weihang Li <liweihang@...wei.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        "Wei Hu(Xavier)" <xavier.huwei@...wei.com>,
        Shaobo Xu <xushaobo2@...wei.com>,
        Doug Ledford <dledford@...hat.com>,
        Lijun Ou <oulijun@...wei.com>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/hns: Fix missing put_device call in hns_roce_get_cfg

On Mon, Jan 10, 2022 at 06:12:34AM +0000, Miaoqian Lin wrote:
> The reference taken by 'of_find_device_by_node()' must be released when
> not needed anymore. And hns_roce_find_pdev() calls
> bus_find_device_by_fwnode(), which calls bus_find_device().
> We also need to drop the reference taken by bus_find_device.
> 
> Fixes: 08805fdbeb2d ("RDMA/hns: Split hw v1 driver from hns roce driver")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> ---
>  drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 1 +
>  1 file changed, 1 insertion(+)

This file was removed in the commit 38d220882426 ("RDMA/hns: Remove
support for HIP06").

BTW, please recheck your patch submission flow, the received emails have
broken "To ..." field that makes reply do not work.

Thanks